github/hugo
1
0
Fork 0
mirror of https://github.com/gohugoio/hugo.git synced 2024-11-21 20:46:30 -05:00
Code Issues Projects Releases Packages Wiki Activity

tpl/collections: Allow first function to return an empty slice

Browse source 
Fixes #5235
This commit is contained in:
Ricardo N Feliciano 2018-09-22 14:58:46 -04:00 committed by Bjørn Erik Pedersen
parent 4f9c109dc5
commit cae07ce84b
3 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
docs/content/en/functions/first.md
View file

@ -25,3 +25,5 @@ aliases: []
{{ .Render "summary" }} {{ .Render "summary" }}
{{ end }} {{ end }}
``` ```
*Note: Exclusive to `first`, LIMIT can be '0' to return an empty array.*

4
tpl/collections/collections.go
View file

@ -215,8 +215,8 @@ func (ns *Namespace) First(limit interface{}, seq interface{}) (interface{}, err
return nil, err return nil, err
} }
if limitv < 1 { if limitv < 0 {
return nil, errors.New("can't return negative/empty count of items from sequence") return nil, errors.New("can't return negative count of items from sequence")
} }
seqv := reflect.ValueOf(seq) seqv := reflect.ValueOf(seq)

1
tpl/collections/collections_test.go
View file

@ -256,6 +256,7 @@ func TestFirst(t *testing.T) {
{int64(2), []int{100, 200, 300}, []int{100, 200}}, {int64(2), []int{100, 200, 300}, []int{100, 200}},
{100, []int{100, 200}, []int{100, 200}}, {100, []int{100, 200}, []int{100, 200}},
{"1", []int{100, 200, 300}, []int{100}}, {"1", []int{100, 200, 300}, []int{100}},
{0, []string{"h", "u", "g", "o"}, []string{}},
{int64(-1), []int{100, 200, 300}, false}, {int64(-1), []int{100, 200, 300}, false},
{"noint", []int{100, 200, 300}, false}, {"noint", []int{100, 200, 300}, false},
{1, nil, false}, {1, nil, false},