mirror of
https://github.com/gohugoio/hugo.git
synced 2024-11-07 20:30:36 -05:00
livereload: Use X-Forwarded-Host
for Codespace
Codespace has 2 types of usage 1. in browser 2. vscode on local computer As long as you select 2 (on local), Hugo handles livereload expectedly. But if you use it in browser, Hugo does not reload on file change, as #9936 said. This issue happens because `CheckOrigin` always fails. Remote server could rewrite request host name. Fix this by respecting `X-Forwarded-Host` header during origin checking After merging this, you can preview changes lively with codespaece in browser. ```sh hugo server --liveReloadPort 443 ``` Close #9936
This commit is contained in:
parent
311b8008bf
commit
8e2fd55923
1 changed files with 7 additions and 1 deletions
|
@ -62,7 +62,13 @@ var upgrader = &websocket.Upgrader{
|
||||||
return false
|
return false
|
||||||
}
|
}
|
||||||
|
|
||||||
if u.Host == r.Host {
|
rHost := r.Host
|
||||||
|
// For Github codespace in browser #9936
|
||||||
|
if forwardedHost := r.Header.Get("X-Forwarded-Host"); forwardedHost != "" {
|
||||||
|
rHost = forwardedHost
|
||||||
|
}
|
||||||
|
|
||||||
|
if u.Host == rHost {
|
||||||
return true
|
return true
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue