github/hugo
1
0
Fork 0
mirror of https://github.com/gohugoio/hugo.git synced 2024-11-21 20:46:30 -05:00
Code Issues Projects Releases Packages Wiki Activity

tpl: Do not return any value in errorf

Browse source 
Fixes #6653
This commit is contained in:
Bjørn Erik Pedersen 2019-12-21 10:26:14 +01:00
parent 1773d71d5b
commit 50cc7fe545
No known key found for this signature in database
GPG key ID: 330E6E2BD4859D8F
3 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
docs/content/en/functions/errorf.md
View file

@ -14,14 +14,14 @@ workson: []
hugoversion: hugoversion:
relatedfuncs: [printf] relatedfuncs: [printf]
deprecated: false deprecated: false
aliases: [] aliases: [/functions/errorf]
--- ---
`errorf` or `warnf` will evaluate a format string, then output the result to the ERROR or WARNING log (and only once per error message to avoid flooding the log). `errorf` or `warnf` will evaluate a format string, then output the result to the ERROR or WARNING log (and only once per error message to avoid flooding the log).
Any ERROR will also cause the build to fail (the `hugo` command will `exit -1`). Any ERROR will also cause the build to fail (the `hugo` command will `exit -1`).
Note that the WARNING will only be printed to the console. Both functions return an empty string, so the messages are only printed to the console.
``` ```
{{ errorf "Failed to handle page %q" .Path }} {{ errorf "Failed to handle page %q" .Path }}

6
tpl/fmt/fmt.go
View file

@ -51,11 +51,11 @@ func (ns *Namespace) Println(a ...interface{}) string {
return _fmt.Sprintln(a...) return _fmt.Sprintln(a...)
} }
// Errorf formats according to a format specifier and returns the string as a // Errorf formats according to a format specifier and logs an ERROR.
// value that satisfies error. // It returns an empty string.
func (ns *Namespace) Errorf(format string, a ...interface{}) string { func (ns *Namespace) Errorf(format string, a ...interface{}) string {
ns.errorLogger.Printf(format, a...) ns.errorLogger.Printf(format, a...)
return _fmt.Sprintf(format, a...) return ""
} }
// Warnf formats according to a format specifier and logs a WARNING. // Warnf formats according to a format specifier and logs a WARNING.

2
tpl/fmt/init.go
View file

@ -53,7 +53,7 @@ func init() {
ns.AddMethodMapping(ctx.Errorf, ns.AddMethodMapping(ctx.Errorf,
[]string{"errorf"}, []string{"errorf"},
[][2]string{ [][2]string{
{`{{ errorf "%s." "failed" }}`, `failed.`}, {`{{ errorf "%s." "failed" }}`, ``},
}, },
) )