github/hugo
1
0
Fork 0
mirror of https://github.com/gohugoio/hugo.git synced 2024-11-21 20:46:30 -05:00
Code Issues Projects Releases Packages Wiki Activity

hugolib: Defer the unlock in orderedMap.Add

Browse source 
Just in case someone tries to recover from the potential panic.
This commit is contained in:
Bjørn Erik Pedersen 2018-04-22 21:32:05 +02:00
parent 474bad34ca
commit 24c662ce6b
No known key found for this signature in database
GPG key ID: 330E6E2BD4859D8F
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
hugolib/orderedMap.go
View file

@ -38,14 +38,13 @@ func newOrderedMapFromStringMapString(m map[string]string) *orderedMap {
func (m *orderedMap) Add(k, v interface{}) { func (m *orderedMap) Add(k, v interface{}) {
m.Lock() m.Lock()
defer m.Unlock()
_, found := m.m[k] _, found := m.m[k]
if found { if found {
panic(fmt.Sprintf("%v already added", v)) panic(fmt.Sprintf("%v already added", v))
} }
m.m[k] = v m.m[k] = v
m.keys = append(m.keys, k) m.keys = append(m.keys, k)
m.Unlock()
} }
func (m *orderedMap) Get(k interface{}) (interface{}, bool) { func (m *orderedMap) Get(k interface{}) (interface{}, bool) {