github/hugo
1
0
Fork 0
mirror of https://github.com/gohugoio/hugo.git synced 2024-11-21 20:46:30 -05:00
Code Issues Projects Releases Packages Wiki Activity

tpl/strings: Remove overflow check in strings.Repeat

Browse source 
The test fails on 32 bit systems. Let it panic instead.
This commit is contained in:
Bjørn Erik Pedersen 2018-06-03 23:23:48 +03:00
parent 90c7749085
commit 0c6c98e401
No known key found for this signature in database
GPG key ID: 330E6E2BD4859D8F
2 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
tpl/strings/strings.go
View file

@ -432,8 +432,6 @@ func (ns *Namespace) Repeat(n, s interface{}) (string, error) {
if sn < 0 { if sn < 0 {
return "", errors.New("strings: negative Repeat count") return "", errors.New("strings: negative Repeat count")
} else if sn > 0 && len(ss)*sn/sn != len(ss) {
return "", errors.New("strings: Repeat count causes overflow")
} }
return _strings.Repeat(ss, sn), nil return _strings.Repeat(ss, sn), nil

3
tpl/strings/strings_test.go
View file

@ -16,7 +16,6 @@ package strings
import ( import (
"fmt" "fmt"
"html/template" "html/template"
"math"
"testing" "testing"
"github.com/gohugoio/hugo/deps" "github.com/gohugoio/hugo/deps"
@ -730,7 +729,7 @@ func TestRepeat(t *testing.T) {
// errors // errors
{"", tstNoStringer{}, false}, {"", tstNoStringer{}, false},
{tstNoStringer{}, "", false}, {tstNoStringer{}, "", false},
{"ab", math.MaxInt64, false}, {"ab", -1, false},
} { } {
errMsg := fmt.Sprintf("[%d] %v", i, test) errMsg := fmt.Sprintf("[%d] %v", i, test)