github/hugo
1
0
Fork 0
mirror of https://github.com/gohugoio/hugo.git synced 2024-11-21 20:46:30 -05:00
Code Issues Projects Releases Packages Wiki Activity

parser: Add WARNING for integer YAML keys

Browse source 
```bash
benchmark                                               old ns/op     new ns/op     delta
BenchmarkStringifyMapKeysStringsOnlyInterfaceMaps-4     3053          2015          -34.00%
BenchmarkStringifyMapKeysStringsOnlyStringMaps-4        5.23          5.18          -0.96%
BenchmarkStringifyMapKeysIntegers-4                     2320          5177          +123.15%

benchmark                                               old allocs     new allocs     delta
BenchmarkStringifyMapKeysStringsOnlyInterfaceMaps-4     6              6              +0.00%
BenchmarkStringifyMapKeysStringsOnlyStringMaps-4        0              0              +0.00%
BenchmarkStringifyMapKeysIntegers-4                     6              14             +133.33%

benchmark                                               old bytes     new bytes     delta
BenchmarkStringifyMapKeysStringsOnlyInterfaceMaps-4     1008          1008          +0.00%
BenchmarkStringifyMapKeysStringsOnlyStringMaps-4        0             0             +0.00%
BenchmarkStringifyMapKeysIntegers-4                     1008          1776          +76.19%
```
Closes #4393
This commit is contained in:
Bjørn Erik Pedersen 2018-02-12 18:47:25 +01:00
parent 10a917dfdc
commit 0816a97a46
No known key found for this signature in database
GPG key ID: 330E6E2BD4859D8F
1 changed files with 15 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
parser/frontmatter.go
View file

@ -23,6 +23,8 @@ import (
"io" "io"
"strings" "strings"
"github.com/gohugoio/hugo/helpers"
"github.com/spf13/cast" "github.com/spf13/cast"
"github.com/BurntSushi/toml" "github.com/BurntSushi/toml"
@ -256,10 +258,20 @@ func stringifyMapKeys(in interface{}) (interface{}, bool) {
} }
case map[interface{}]interface{}: case map[interface{}]interface{}:
res := make(map[string]interface{}) res := make(map[string]interface{})
var (
ok bool
err error
)
for k, v := range in { for k, v := range in {
ks, err := cast.ToStringE(k) var ks string
if err != nil {
ks = fmt.Sprintf("%v", k) if ks, ok = k.(string); !ok {
ks, err = cast.ToStringE(k)
if err != nil {
ks = fmt.Sprintf("%v", k)
}
// TODO(bep) added in Hugo 0.37, remove some time in the future.
helpers.DistinctFeedbackLog.Printf("WARNING: YAML data/frontmatter with keys of type %T is since Hugo 0.37 converted to strings", k)
} }
if vv, replaced := stringifyMapKeys(v); replaced { if vv, replaced := stringifyMapKeys(v); replaced {
res[ks] = vv res[ks] = vv