mirror of
https://github.com/hedgedoc/hedgedoc.git
synced 2024-11-22 01:36:29 -05:00
277e2fb1ca
By checking the "old" password of the user prior to a password change, the password change function is more secured against abuse. Signed-off-by: Erik Michelson <github@erik.michelson.eu>
242 lines
8.3 KiB
TypeScript
242 lines
8.3 KiB
TypeScript
/*
|
|
* SPDX-FileCopyrightText: 2021 The HedgeDoc developers (see AUTHORS file)
|
|
*
|
|
* SPDX-License-Identifier: AGPL-3.0-only
|
|
*/
|
|
|
|
/* eslint-disable
|
|
@typescript-eslint/no-unsafe-assignment,
|
|
@typescript-eslint/no-unsafe-member-access
|
|
*/
|
|
import request from 'supertest';
|
|
|
|
import { AuthConfig } from '../../src/config/auth.config';
|
|
import { LoginDto } from '../../src/identity/local/login.dto';
|
|
import { RegisterDto } from '../../src/identity/local/register.dto';
|
|
import { UpdatePasswordDto } from '../../src/identity/local/update-password.dto';
|
|
import { UserRelationEnum } from '../../src/users/user-relation.enum';
|
|
import { checkPassword } from '../../src/utils/password';
|
|
import { setupSessionMiddleware } from '../../src/utils/session';
|
|
import { TestSetup } from '../test-setup';
|
|
|
|
describe('Auth', () => {
|
|
let testSetup: TestSetup;
|
|
|
|
let username: string;
|
|
let displayname: string;
|
|
let password: string;
|
|
|
|
beforeAll(async () => {
|
|
testSetup = await TestSetup.create();
|
|
|
|
const authConfig = testSetup.configService.get('authConfig') as AuthConfig;
|
|
setupSessionMiddleware(testSetup.app, authConfig);
|
|
await testSetup.app.init();
|
|
|
|
username = 'hardcoded';
|
|
displayname = 'Testy';
|
|
password = 'test_password';
|
|
});
|
|
|
|
describe('POST /auth/local', () => {
|
|
it('works', async () => {
|
|
const registrationDto: RegisterDto = {
|
|
displayname: displayname,
|
|
password: password,
|
|
username: username,
|
|
};
|
|
await request(testSetup.app.getHttpServer())
|
|
.post('/api/private/auth/local')
|
|
.set('Content-Type', 'application/json')
|
|
.send(JSON.stringify(registrationDto))
|
|
.expect(201);
|
|
const newUser = await testSetup.userService.getUserByUsername(username, [
|
|
UserRelationEnum.IDENTITIES,
|
|
]);
|
|
expect(newUser.displayName).toEqual(displayname);
|
|
await expect(newUser.identities).resolves.toHaveLength(1);
|
|
await expect(
|
|
checkPassword(
|
|
password,
|
|
(await newUser.identities)[0].passwordHash ?? '',
|
|
),
|
|
).resolves.toBeTruthy();
|
|
});
|
|
describe('fails', () => {
|
|
it('when the user already exits', async () => {
|
|
const username2 = 'already_existing';
|
|
await testSetup.userService.createUser(username2, displayname);
|
|
const registrationDto: RegisterDto = {
|
|
displayname: displayname,
|
|
password: password,
|
|
username: username2,
|
|
};
|
|
await request(testSetup.app.getHttpServer())
|
|
.post('/api/private/auth/local')
|
|
.set('Content-Type', 'application/json')
|
|
.send(JSON.stringify(registrationDto))
|
|
.expect(409);
|
|
});
|
|
it('when registration is disabled', async () => {
|
|
testSetup.configService.get('authConfig').local.enableRegister = false;
|
|
const registrationDto: RegisterDto = {
|
|
displayname: displayname,
|
|
password: password,
|
|
username: username,
|
|
};
|
|
await request(testSetup.app.getHttpServer())
|
|
.post('/api/private/auth/local')
|
|
.set('Content-Type', 'application/json')
|
|
.send(JSON.stringify(registrationDto))
|
|
.expect(400);
|
|
testSetup.configService.get('authConfig').local.enableRegister = true;
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('PUT /auth/local', () => {
|
|
const newPassword = 'new_password';
|
|
let cookie = '';
|
|
beforeEach(async () => {
|
|
const loginDto: LoginDto = {
|
|
password: password,
|
|
username: username,
|
|
};
|
|
const response = await request(testSetup.app.getHttpServer())
|
|
.post('/api/private/auth/local/login')
|
|
.set('Content-Type', 'application/json')
|
|
.send(JSON.stringify(loginDto))
|
|
.expect(201);
|
|
cookie = response.get('Set-Cookie')[0];
|
|
});
|
|
it('works', async () => {
|
|
// Change password
|
|
const changePasswordDto: UpdatePasswordDto = {
|
|
currentPassword: password,
|
|
newPassword: newPassword,
|
|
};
|
|
await request(testSetup.app.getHttpServer())
|
|
.put('/api/private/auth/local')
|
|
.set('Content-Type', 'application/json')
|
|
.set('Cookie', cookie)
|
|
.send(JSON.stringify(changePasswordDto))
|
|
.expect(200);
|
|
// Successfully login with new password
|
|
const loginDto: LoginDto = {
|
|
password: newPassword,
|
|
username: username,
|
|
};
|
|
const response = await request(testSetup.app.getHttpServer())
|
|
.post('/api/private/auth/local/login')
|
|
.set('Content-Type', 'application/json')
|
|
.send(JSON.stringify(loginDto))
|
|
.expect(201);
|
|
cookie = response.get('Set-Cookie')[0];
|
|
// Reset password
|
|
const changePasswordBackDto: UpdatePasswordDto = {
|
|
currentPassword: newPassword,
|
|
newPassword: password,
|
|
};
|
|
await request(testSetup.app.getHttpServer())
|
|
.put('/api/private/auth/local')
|
|
.set('Content-Type', 'application/json')
|
|
.set('Cookie', cookie)
|
|
.send(JSON.stringify(changePasswordBackDto))
|
|
.expect(200);
|
|
});
|
|
it('fails, when registration is disabled', async () => {
|
|
testSetup.configService.get('authConfig').local.enableLogin = false;
|
|
// Try to change password
|
|
const changePasswordDto: UpdatePasswordDto = {
|
|
currentPassword: password,
|
|
newPassword: newPassword,
|
|
};
|
|
await request(testSetup.app.getHttpServer())
|
|
.put('/api/private/auth/local')
|
|
.set('Content-Type', 'application/json')
|
|
.set('Cookie', cookie)
|
|
.send(JSON.stringify(changePasswordDto))
|
|
.expect(400);
|
|
// enable login again
|
|
testSetup.configService.get('authConfig').local.enableLogin = true;
|
|
// new password doesn't work for login
|
|
const loginNewPasswordDto: LoginDto = {
|
|
password: newPassword,
|
|
username: username,
|
|
};
|
|
await request(testSetup.app.getHttpServer())
|
|
.post('/api/private/auth/local/login')
|
|
.set('Content-Type', 'application/json')
|
|
.send(JSON.stringify(loginNewPasswordDto))
|
|
.expect(401);
|
|
// old password does work for login
|
|
const loginOldPasswordDto: LoginDto = {
|
|
password: password,
|
|
username: username,
|
|
};
|
|
await request(testSetup.app.getHttpServer())
|
|
.post('/api/private/auth/local/login')
|
|
.set('Content-Type', 'application/json')
|
|
.send(JSON.stringify(loginOldPasswordDto))
|
|
.expect(201);
|
|
});
|
|
it('fails, when old password is wrong', async () => {
|
|
// Try to change password
|
|
const changePasswordDto: UpdatePasswordDto = {
|
|
currentPassword: 'wrong',
|
|
newPassword: newPassword,
|
|
};
|
|
await request(testSetup.app.getHttpServer())
|
|
.put('/api/private/auth/local')
|
|
.set('Content-Type', 'application/json')
|
|
.set('Cookie', cookie)
|
|
.send(JSON.stringify(changePasswordDto))
|
|
.expect(401);
|
|
// old password still does work for login
|
|
const loginOldPasswordDto: LoginDto = {
|
|
password: password,
|
|
username: username,
|
|
};
|
|
await request(testSetup.app.getHttpServer())
|
|
.post('/api/private/auth/local/login')
|
|
.set('Content-Type', 'application/json')
|
|
.send(JSON.stringify(loginOldPasswordDto))
|
|
.expect(201);
|
|
});
|
|
});
|
|
|
|
describe('POST /auth/local/login', () => {
|
|
it('works', async () => {
|
|
testSetup.configService.get('authConfig').local.enableLogin = true;
|
|
const loginDto: LoginDto = {
|
|
password: password,
|
|
username: username,
|
|
};
|
|
await request(testSetup.app.getHttpServer())
|
|
.post('/api/private/auth/local/login')
|
|
.set('Content-Type', 'application/json')
|
|
.send(JSON.stringify(loginDto))
|
|
.expect(201);
|
|
});
|
|
});
|
|
|
|
describe('DELETE /auth/logout', () => {
|
|
it('works', async () => {
|
|
testSetup.configService.get('authConfig').local.enableLogin = true;
|
|
const loginDto: LoginDto = {
|
|
password: password,
|
|
username: username,
|
|
};
|
|
const response = await request(testSetup.app.getHttpServer())
|
|
.post('/api/private/auth/local/login')
|
|
.set('Content-Type', 'application/json')
|
|
.send(JSON.stringify(loginDto))
|
|
.expect(201);
|
|
const cookie = response.get('Set-Cookie')[0];
|
|
await request(testSetup.app.getHttpServer())
|
|
.delete('/api/private/auth/logout')
|
|
.set('Cookie', cookie)
|
|
.expect(200);
|
|
});
|
|
});
|
|
});
|