github/hedgedoc
1
0
Fork 0
mirror of https://github.com/hedgedoc/hedgedoc.git synced 2024-11-29 03:34:15 -05:00
Code Issues Projects Releases Packages Wiki Activity
4397 commits 39 branches 47 tags 112 MiB
Commit graph

64 commits

Author SHA1 Message Date
David Mehren
acaefb3996
refactor(note-permissions-dto): do not embed User objects 
This is part of an effort to consistently not embed User objects
in API responses. Usernames are returned instead.

Signed-off-by: David Mehren <git@herrmehren.de>
 2022-01-17 11:56:09 +01:00
David Mehren
05e534a7d6
refactor(note-metadata): rename date attributes 
This is part of an effort to name all date attributes
consistently.

Signed-off-by: David Mehren <git@herrmehren.de>
 2022-01-16 22:04:53 +01:00
David Mehren
3c0c11e3d4
refactor(note): lazy-load relations 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-12-13 21:45:03 +01:00
Philip Molares
16cd42f197 test: fix note e2e test 'fails with non-existing alias' 
Because the rejection now happens automatically in the permissions guard it does not get to the controller method and does not report the Content-Type to text/markdown

Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-12-02 20:41:14 +01:00
Philip Molares
40e8acb6bb test: fix note e2e test 'fails, when user can't read note' 
Because the rejection now happens automatically in the permissions guard it now returns a 403 instead of 401

Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-12-02 20:41:14 +01:00
David Mehren
9c08ff94fe
fix(note): fix type for owner param 
To make the create method easier to use in conjunction
with the authentication framework, this commit changes the type of
the `owner` parameter from `User | undefined` to `User | null`.

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-11-14 21:46:04 +01:00
David Mehren
c6cac58a67
Update API routes in public API E2E tests 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-10-21 20:17:03 +02:00
David Mehren
9489fbaa79
Migrate private notes API E2E test to global TestSetup 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-10-21 19:52:41 +02:00
David Mehren
9539581219
Migrate public notes API E2E test to global TestSetup 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-10-21 19:51:57 +02:00
Yannick Bungers
d33cfa4541 fix username spelling from userName 
Signed-off-by: Yannick Bungers <git@innay.de>
 2021-10-13 22:54:00 +02:00
Philip Molares
9f38b9036c test: fix e2e tests to handle the new aliases 
Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-09-22 20:43:45 +02:00
David Mehren
7c618e7f9f
Merge pull request #1613 from hedgedoc/merge/tokenGuardAndStrategy 2021-09-06 12:12:44 +02:00
David Mehren
5c7a787d7e
MediaService: Refactor saveFile 
The function now expects a `Note` object instead of a noteId
and a `User` instead of a username to
make it more consistent with other functions.

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-09-04 22:40:15 +02:00
David Mehren
f667410b51
Public API: Test that forbidden notes can't be accessed 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-09-04 22:40:15 +02:00
Philip Molares
c22727dad7 refactor: move TokenAuthGuard in the same file as TokenStrategy 
This should help to make clear why code is executed when the TokenAuthGuard is encountered by a request. Currently, one has to connect both files via the string 'token', which is a bit cryptic

Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-09-04 18:09:17 +02:00
David Mehren
bcc9ec9c75
Enforce import order with prettier 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-08-29 18:45:46 +02:00
Philip Molares
fb79f44b1f chore(test): Change test to work with publicId 
Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-05-17 20:27:44 +02:00
David Mehren
5e61de9bd5
Use node12 TypeScript base config 
TypeScript recommends using a base config from https://github.com/tsconfig/bases.

Using this config reduces compile times by ~30%
and the size of the dist folder by ~45%.
It also enables the recommended `esModuleInterop` option,
which necessitated some changes to imports.
See also https://www.typescriptlang.org/docs/handbook/release-notes/typescript-2-7.html#support-for-import-d-from-cjs-from-commonjs-modules-with---esmoduleinterop

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-04-29 22:55:01 +02:00
Yannick Bungers
0bad4827bf
Merge pull request #1179 from hedgedoc/util/replaceNull 2021-04-25 21:03:45 +02:00
Philip Molares
38ab6dc27b NotesE2ETest: Changed test for title and description 
They should not return null and that's correctly tested now.

Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-04-24 21:33:47 +02:00
Philip Molares
1f897636bb PublicApi: Add option to keep media to DELETE /notes/{note} 
This adds a body to the route DELETE /notes/{note} of the public api to specify if the associated media uploads of the note should be kept or deleted.

Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-04-22 23:13:13 +02:00
Yannick Bungers
eaa5254418
Merge pull request #1039 from hedgedoc/fix/permissionsCreationAndFinding 2021-04-18 22:45:24 +02:00
Philip Molares
c6612f55c7 PublicNotesE2E: Add extra test for note deletion 
This test checks if permission are correctly set and no error is thrown if the note is deleted.

Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-04-18 22:35:28 +02:00
Philip Molares
434bc55bab Tests: Removed all eslint-disable lines 
As we now disable what we don't need in the eslint config, we don't need this anymore.

Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-04-16 10:14:05 +02:00
Philip Molares
a2e7616484 E2ETests: Use recursive for 'uploads/' deletion. 
This ensures the folder is always deleted, even if there are still files (from previous broken tests) in it.

Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-04-01 00:18:24 +02:00
Philip Molares
69550a8243 PublicE2E: Remove uploaded files after test 
This way the tests can run in any order as some of the media tests rely on an empty (or non-existing) uploads directory.
Also the me e2e test was renamed to the correct name.

Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-03-24 22:20:20 +01:00
Philip Molares
381718f0eb Config: Move config mocks in own folder 
To clean up the config folder, all mocks are now in it's own folder.

Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-03-21 19:59:05 +01:00
Philip Molares
9b427dc6d1 NotesE2ETest: Add GET /api/v2/notes/{note}/media test 
Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-03-21 19:22:40 +01:00
Philip Molares
168d85778c Docs: Add more documentation to the public api 
Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-03-20 10:18:44 +01:00
Philip Molares
1df0bda61d NotesService: Add e2e tests for forbidden note alias 
Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-03-06 17:49:33 +01:00
Philip Molares
2f028a4aae Config: Add forbiddenNoteIds to AppConfig 
Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-02-27 23:04:49 +01:00
David Mehren
4d94739a9f
Fix various ESLint errors in E2E tests 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-02-27 16:11:27 +01:00
Yannick Bungers
e081bd196b Rename getNoteContentByNote to getNoteContent 
Signed-off-by: Yannick Bungers <git@innay.de>
 2021-02-22 22:34:18 +01:00
Philip Molares
5f49cb8d48 NotesService: Replace noteByIdOrAlias with note as parameter 
As the NotesController has the note already, because it checked with it if the user has the permission to perform the action, it's not necessary to get the note from the DB again, instead we should just provide the note to the functions directly.

Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-02-20 19:51:27 +01:00
Philip Molares
54286d589d NotesE2ETests: Ensure posting the same note alias twice fails 
Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-02-20 19:51:27 +01:00
Philip Molares
336117cef5 NotesService: Rename getCurrentContent to getNoteContentByNote 
The new name should better explain what this functions does.

Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-02-19 13:36:01 +01:00
Philip Molares
8e9717c92a NotesE2E: Fix e2e test 
split success and fail cases in separate tests for better readability
add the correct user to all notes created by service (instead of api) to make the permissions checks viable.
extracted test content of notes to a global variable.

Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-02-18 22:25:55 +01:00
Philip Molares
a7f35aaeec tests: Fix tests as part of the DTO Refactor 
Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-01-31 00:11:58 +01:00
Philip Molares
fd70b2d121 auth: fixes unit and e2e tests 
adds MockAuthGuard which always return user 'hardcoded'

Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-01-25 21:30:02 +01:00
Philip Molares
9c3d329bc9 tests: Removed unnecessary import of appConfigMock 
As suggested by an review of David Mehren

Co-authored by: David Mehren <git@herrmehren.de>

Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-01-19 12:45:36 +01:00
Philip Molares
2c4098dc55 config: splits config in multiple files 
splits the big appConfig in multiple configs
adds media.config.mock.ts

Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-01-17 21:19:45 +01:00
Yannick Bungers
0d95c29df2
Merge pull request #709 from hedgedoc/fix/api-notes-metadata 2021-01-15 22:47:52 +01:00
David Mehren
9f170bca4c
FilesystemBackend: Use scoped appConfig 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-01-13 21:45:23 +01:00
David Mehren
6301a264dd
NotesService: updateNoteByIdOrAlias should return the new note 
Fixes #702

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-01-10 20:31:56 +01:00
David Mehren
c9a998ab73
Note E2E tests: Check that create & update dates are updated correctly 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-01-10 20:12:39 +01:00
David Mehren
32feb5ee10
NotesService: rename getLastRevision to getLatestRevision 
This fixes an inconsistency with `RevisionsService`

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-01-10 20:12:39 +01:00
David Mehren
141dc349e3
NotesController: Do not crash on nonexistent notes 
This commit adds proper error handling and returns 404 when a note does not exist.
Previously, we leaked the `NotInDBError` and sent a 500 status code.

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-01-09 22:58:16 +01:00
David Mehren
f81e67a3a1
Format with Prettier 2 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-01-06 23:49:45 +01:00
Tilman Vatteroth
0c56466dc1
Change year in copyright to 2021 
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
 2021-01-06 22:10:19 +01:00
Philip Molares
6896daa62a added reuse information 
Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-01-05 22:12:38 +01:00