This fix needs a little bit of explanation. Normally the 'keyUp' prevent is preferred because it fires after being sure, that not some buttons more belong to the shortcut. Additionally some platforms set the key-property of the 'keyDown'-event to the composition result of the key-combination thus resolving under certain environments to '€' while in other environments to 'e'.
The browser's event flow is as following: keyDown -> keyPress -> textInput -> keyUp.
As the keyUp-event is too late (after textinput) and the keyPress-event does not work properly with the modifiers, we felt compelled to use 'keyDown' and watch for 'e' as well as '€' key-properties. If some other keyboard locale does output different characters than these two, that person got a problem - meaning no functionality of the shortcut. But still better than nothing.
Previously, single dashes were used for associatons, which makes PlantUML layout all of them in an horizontal line. I changed that to two dashes so that PlantUML uses normal layouting. I think that is far clearer.
(See https://plantuml.com/class-diagram for more on layouting)
Signed-off-by: Nicolas Lenz <nicolas@eisfunke.com>
While running tests, cypress records videos of each one and processes them afterwards. This needs some resources we could save to reduce the CI runtime as we don't use or upload these videos.
* Replaced connection indicator in editor top bar with user-menu
* Added basic layout of bottom document bar
* Fixed margins between elements
* Reorganized document-bar
* Added dividers into toolbar
* Move files from task-bar to document-bar and remove test file
* moved connection-indicator components into its own folder
* moved document bar to the top
* moved connection-indicator once again
* Change design
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
* New idea for timestamps
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
* Add css
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
* Revert "Add css"
This reverts commit 6780aa05
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
* Revert "New idea for timestamps"
This reverts commit bf2891e1
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
* split import / export
* Made version input field to a common component
* added read-only modal
added document-time
added placeholder text for permissions
* remove flex-nowrap from editor toolbar
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
* Add codimd permission menu
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
* Move permission picker to the right
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
* add use memo
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
* Add user-select-none to documenttime component
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
* added status-bar
* fixed status-bar
* Add document info mock
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
* changed published to share in i18n
* reordered document bar
moved share modal in it's own component
* changed the divider color in the toolbar
* Add details to document info
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
* Add pin mock button
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
* Restructure toolbar after rebase and extract EmojiPicker+Button into component
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
* Correct linue number output
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
* Add some space into status bar
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
* Cleanup code to make ESLint happy
* Fix Toc button position
* Added link to presentation mode button
* Cache codemirror props
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
* Fix code blocks not being completely visible
* Improve document info modal
- The document info timeline always wrapped the received moment.js-object into a new moment.js object instead of directly using the given one.
- The timestamps were configured to be displayed without suffix, but this is necessary to support valid translation grammar.
- There was no margin between the icons and the texts.
* Highlighted user name in document-info modal
* Add avatar icon to document-info modal
* Improved english translation of the share-info
* Improve performance of copyable-fields by using useCallback
* Add translation keys for pin-to-history button
* Forwarded note title to editor-menu for deletion modal info
* Add placeholders to translations
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
* change translation
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
* Change permission dropdown to permission button
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
* Fix translations of emoji-picker and preferences
* remove unused imports
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
* Add alt attribute
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
* Fix share button and i18n files
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
* Fix use of i18n keys
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
* Use modal-body
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
* useCallback
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
* Use more specific i18n key
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
* Add a new entry and move i18n key for usercontribution
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
* Fix i18nkey für shareLink
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
* remove unused i18nkey
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
* Rename component DocumentInfo to DocumentInfoButton
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
* Extract revision button code into own component
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
* wrap buttons in navbar-nav
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
* organize imports
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
* organize imports
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
* Added editor-preferences modal
* Added functionality to preferences modal
* Activated search and replace feature in CodeMirror
* pdf export unavailability notice (#403)
* added pdf export unavailability notice with link to FAQ
as many users ask all the time why this was removed and when they'll get it back, this seemed like a fine solution in the meantime.
Co-authored-by: Erik Michelson <github@erik.michelson.eu>
* Refactored editor-preferences to just use one generic select component
* Fixed warnings regarding duplicated controlId and missing useCb-deps
* Reorganized translation keys
* Fixed i18n indentation for POEditor.com
* Added translation key for 'avatar of ...'
* Remove fragment
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
* Use user-avatar in document-info-line.tsx
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
* Revert changes in user-avatar and solve the problem otherwise
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
* Removed unnecessary import
* Removed another unnecessary import
* Refactored EditorPreferenceSelect to use enum and automatic type conversions
* Remove unused CodeMirror reference
* Fix spacing problem
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
* Increate size of image
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
* fixed share-link's space around the copyable-field
Co-authored-by: Philip Molares <philip.molares@udo.edu>
Co-authored-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
Co-authored-by: Philip Molares <git@molar.es>
