Commit graph

6248 commits

Author SHA1 Message Date
Philip Molares
796b8294cf docs: improved auto-generated openapi docs
With these additional annotations the openapi docs under `/apidoc` and `/private/apidoc` will be improved by adding errors that the requests can return

Signed-off-by: Philip Molares <philip.molares@udo.edu>
2022-02-07 00:08:41 +01:00
Philip Molares
2bc8c0d6da refactor(public-api): use TokenAuthGuard on controller not method level
As the public api is nearly completely protected by the TokenAuthGuard it seems unnecessarily verbose to add the guard to every method in the controllers, when an annotation at the top of the controller would be sufficient.

Signed-off-by: Philip Molares <philip.molares@udo.edu>
2022-02-07 00:08:41 +01:00
Philip Molares
d142cbadeb refactor: remove try catches from controllers
This is handled by the ErrorExceptionMapping class

Signed-off-by: Philip Molares <philip.molares@udo.edu>
2022-02-07 00:08:41 +01:00
Philip Molares
2cd4f412e5 feat: add ErrorExceptionMapping as a global filter
This filters all error that the controller will throw and either maps
them to the correct HttpException if they are internal errors like
NotInDBError, or just leaves them be if they are not part in the map.

Signed-off-by: Philip Molares <philip.molares@udo.edu>
2022-02-07 00:08:41 +01:00
Philip Molares
2c7e82680e feat: add additional default descriptions for HttpExceptions
Signed-off-by: Philip Molares <philip.molares@udo.edu>
2022-02-07 00:08:41 +01:00
Philip Molares
d0477a5e34 refactor: omit error mapping in GetNoteInterceptor
Because this mapping will now be done with the ErrorExceptionMapping class, the mapping will be omitted in the interceptor.

Signed-off-by: Philip Molares <philip.molares@udo.edu>
2022-02-07 00:08:41 +01:00
Philip Molares
4ad7ad368c feat: add error-mapping
The ErrorExceptionMapping class maps internal error to nestjs's appropriate HttpException.
The object returned by those HttpExceptions is now changed to include the name of the intern error code and error message instead of statusCode and error message as is default. This makes it possible to more easily programmatically distinguish between two errors that map to the same HttpException and only differ in the error message.
The statusCode was unnecessary, because any user of the api gets this information already by which HttpException was used.

Signed-off-by: Philip Molares <philip.molares@udo.edu>
2022-02-07 00:08:41 +01:00
Philip Molares
451dedef15 refactor: getNoteByIdOrAlias throws NotInDBError instead of ForbiddenIdError for an id on the forbidden list
It's not really necessary to tell the user via get that this id is forbidden, it will not be there and as such NotInDBError is the correct message to the user

Signed-off-by: Philip Molares <philip.molares@udo.edu>
2022-02-07 00:08:41 +01:00
Philip Molares
4500caf882 refactor: move error messages from controller to service
Signed-off-by: Philip Molares <philip.molares@udo.edu>
2022-02-07 00:08:41 +01:00
Philip Molares
f672c5179f test: remove controller tests
These test files are only autogenerated and don't have any benefit. Any behaviour one would test with them are (or at least should) already be covered by our e2e tests.

Signed-off-by: Philip Molares <philip.molares@udo.edu>
2022-02-06 20:57:34 +01:00
Tilman Vatteroth
eabc941c8f
Add commit hash to version on netlify deployment (#1838) 2022-02-06 20:38:40 +01:00
Erik Michelson
757f957e0a Add main netlify deployment on GH actions
Signed-off-by: Erik Michelson <github@erik.michelson.eu>
2022-02-06 15:13:06 +01:00
Renovate Bot
d2db5a0cb8 chore(deps): update dependency mkdocs-material to v8.1.10
Signed-off-by: Renovate Bot <bot@renovateapp.com>
2022-02-06 12:14:58 +00:00
Renovate Bot
720bdefb66 Update dependency @fontsource/source-sans-pro to v4.5.3
Signed-off-by: Renovate Bot <bot@renovateapp.com>
2022-02-05 20:54:58 +01:00
Tilman Vatteroth
57f01e8903 Replace "cypress-file-upload" with cypress selectFile
Signed-off-by: Tilman Vatteroth <git@tilmanvatteroth.de>
2022-02-05 20:33:28 +01:00
renovate[bot]
a32984e052
Update dependency sass to v1.49.7 (#1827)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-02-05 19:04:55 +00:00
Renovate Bot
2cdb4adbc2 Update dependency jest to v27.5.0
Signed-off-by: Renovate Bot <bot@renovateapp.com>
2022-02-05 19:50:53 +01:00
renovate[bot]
b30007fcad
Update dependency copy-webpack-plugin to v10.2.4 (#1825)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-02-05 18:35:18 +00:00
renovate[bot]
281444ff90
Update dependency flowchart.js to v1.17.1 (#1826)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-02-05 17:54:21 +00:00
renovate[bot]
422e9adeea
Update dependency cypress to v9.4.1 (#1830)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-02-05 18:53:49 +01:00
Renovate Bot
95d140ef3b Update dependency @svgr/webpack to v6.2.1
Signed-off-by: Renovate Bot <bot@renovateapp.com>
2022-02-05 18:45:47 +01:00
Renovate Bot
b5a16c2a13 Update definitely typed
Signed-off-by: Renovate Bot <bot@renovateapp.com>
2022-02-05 18:45:28 +01:00
Renovate Bot
02b855f655 Update dependency sharp to v0.30.0
Signed-off-by: Renovate Bot <bot@renovateapp.com>
2022-02-05 18:44:03 +01:00
Renovate Bot
4b34f94730 chore(deps): update dependency jest to v27.5.0
Signed-off-by: Renovate Bot <bot@renovateapp.com>
2022-02-05 12:27:24 +01:00
Renovate Bot
39eab69c6c chore(deps): update dependency @types/node to v16.11.22
Signed-off-by: Renovate Bot <bot@renovateapp.com>
2022-02-05 11:34:48 +01:00
Renovate Bot
c0f7178891 chore(deps): update linters to v5.10.2
Signed-off-by: Renovate Bot <bot@renovateapp.com>
2022-02-05 11:34:25 +01:00
Renovate Bot
cde9a2f66a chore(deps): update dependency @trivago/prettier-plugin-sort-imports to v3.2.0
Signed-off-by: Renovate Bot <bot@renovateapp.com>
2022-02-05 11:34:09 +01:00
renovate[bot]
76e30d8ff3
Update dependency netlify-cli to v8.16.1 (#1831)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-02-05 01:40:33 +00:00
renovate[bot]
b70023167c
Update linters (#1828)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-02-05 01:32:59 +00:00
renovate[bot]
d2309d9bec
Update dependency @testing-library/jest-dom to v5.16.2 (#1824)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-02-05 02:19:49 +01:00
Renovate Bot
3afd11037f Lock file maintenance
Signed-off-by: Renovate Bot <bot@renovateapp.com>
2022-02-02 20:40:09 +01:00
Yannick Bungers
42ad99e20b Replace fs.rmdir recursive by fs.rm recursive
fs.rmdir(path, { recursive: true}) is deprecated and
is replaced by fs.rm(path, { recursive: true}).

Signed-off-by: Yannick Bungers <git@innay.de>
2022-01-31 08:55:42 +01:00
Renovate Bot
e4a9562455 chore(deps): lock file maintenance
Signed-off-by: Renovate Bot <bot@renovateapp.com>
2022-01-31 02:19:21 +00:00
Philip Molares
2d8d29cf20 refactor(config): type config mocks
To minimize type errors, when the config objects are changed, this commit introduces types to the mock config object accordingly.

Signed-off-by: Philip Molares <philip.molares@udo.edu>
2022-01-30 22:19:50 +01:00
Philip Molares
6c82b95ea2 refactor(config): introduce new interface MediaBackendConfig
This interface is needed to help to use types in some cases, where it didn't work before.

Signed-off-by: Philip Molares <philip.molares@udo.edu>
2022-01-30 22:19:50 +01:00
Philip Molares
f4a580cf2a refactor(config): extract note config from app config
This commit separates the app config object from a new note config object. This was done to separate different concerns in different config files. Especially if the number of settings that are about notes increase, it is a good idea to keep them separate from the app config.

Signed-off-by: Philip Molares <philip.molares@udo.edu>
2022-01-30 22:19:50 +01:00
Tilman Vatteroth
ca5dae3f82 Add new visit functions in e2e tests
Signed-off-by: Tilman Vatteroth <git@tilmanvatteroth.de>
2022-01-30 22:13:41 +01:00
Philip Molares
566b3009b6
feat: sort tags alphabetically (#1818)
Signed-off-by: Philip Molares <philip.molares@udo.edu>
2022-01-30 22:10:30 +01:00
Erik Michelson
e671aa4aa8
Fix netlify not using aliases containing a slash (#1819) 2022-01-30 21:57:58 +01:00
Renovate Bot
baa6606729 chore(deps): update dependency mkdocs-material to v8.1.9
Signed-off-by: Renovate Bot <bot@renovateapp.com>
2022-01-30 11:20:21 +00:00
Renovate Bot
fa0bea492e Update dependency copy-webpack-plugin to v10.2.3
Signed-off-by: Renovate Bot <bot@renovateapp.com>
2022-01-29 18:59:06 +01:00
Renovate Bot
407bd27617 chore(deps): update dependency eslint-plugin-jest to v26
Signed-off-by: Renovate Bot <bot@renovateapp.com>
2022-01-29 17:21:30 +01:00
Renovate Bot
84320f6203 fix(deps): update dependency @nestjs/swagger to v5.2.0
Signed-off-by: Renovate Bot <bot@renovateapp.com>
2022-01-29 17:20:42 +01:00
Renovate Bot
d249263632 chore(deps): update dependency eslint to v8.8.0
Signed-off-by: Renovate Bot <bot@renovateapp.com>
2022-01-29 17:20:13 +01:00
Renovate Bot
18b265cf09 fix(deps): update dependency joi to v17.6.0
Signed-off-by: Renovate Bot <bot@renovateapp.com>
2022-01-29 17:13:18 +01:00
Renovate Bot
98d3abd4ef Update dependency netlify-cli to v8.15.0
Signed-off-by: Renovate Bot <bot@renovateapp.com>
2022-01-29 12:57:17 +01:00
Renovate Bot
3a01e0803f Update dependency eslint to v8.8.0
Signed-off-by: Renovate Bot <bot@renovateapp.com>
2022-01-29 12:51:46 +01:00
Renovate Bot
472452115d fix(deps): update dependency @types/minio to v7.0.12
Signed-off-by: Renovate Bot <bot@renovateapp.com>
2022-01-29 05:35:47 +00:00
Renovate Bot
bb81873229 chore(deps): update linters to v5.10.1
Signed-off-by: Renovate Bot <bot@renovateapp.com>
2022-01-29 03:58:46 +00:00
Renovate Bot
05d0591386 Update i18next
Signed-off-by: Renovate Bot <bot@renovateapp.com>
2022-01-28 20:56:40 +01:00