2467b125 mistakenly applied the sanitize function
to the log messages *after* the color was applied.
This commit reverses the order to un-break colored logs.
Signed-off-by: David Mehren <git@herrmehren.de>
This explains how a developer is able to get a ldap server up and running and configure HedgeDoc to use it quickly.
Signed-off-by: Philip Molares <philip.molares@udo.edu>
This is used to implement a custom passport strategy for ldap auth since the passport-ldap package can only handle one ldap server and not multiple like we want.
This dependency was chosen, because it's the same lib that powers the passport-ldap package used in HedgeDoc 1.
Signed-off-by: Philip Molares <philip.molares@udo.edu>
This is used to implement a custom passport strategy for ldap auth since the passport-ldap package can only handle one ldap server and not multiple like we want.
Signed-off-by: Philip Molares <philip.molares@udo.edu>
This tests the ldap part of the authConfig. Other tests shall be added as the auth method is implemented.
Signed-off-by: Philip Molares <philip.molares@udo.edu>
If an empty string or undefined is provided the method should not return [], but undefined instead. This way defaults defined in Joi function as expected.
Signed-off-by: Philip Molares <philip.molares@udo.edu>
The method should only change error messages if it was called with the correct parameters. Otherwise the function would change e.g `.url` in the error message to `_URL` and the regex is not able to change the front of the error message.
Signed-off-by: Philip Molares <philip.molares@udo.edu>
Okay I'm just done. Firefox in our current CI is just the WORST. It is slower than chrome and crashes A LOT! Like really! The e2e workflows of some PRs have to run 4 or 5 times because firefox decides to just lose the connection.
This may also be caused by the performance of GHA, but right now it's easier to (temporally) remove firefox than switching to a whole new CI.
Just to be clear: I know that this step isn't optimal. I know that a huge part of our community uses firefox. But right now the flakiness of the firefox CI runs drives me crazy!
At the moment we need the e2e tests just for our development to make sure that we don't accidentally break something.
We can re-add firefox again when it's stable to use. Or when we have shifted enough of the e2e tests to jest. It would be nice to test other browsers (like safari or edge) as well.
Signed-off-by: Tilman Vatteroth <git@tilmanvatteroth.de>
