From f16b3c0fe64d4f90c8c0a9e4237e574a9202afe2 Mon Sep 17 00:00:00 2001 From: Erik Michelson Date: Mon, 9 Jan 2023 01:48:59 +0100 Subject: [PATCH] fix(redux): avoid state mutation in history redux When updating the data of a note in the redux, the old state element gets manipulated and will be dispatched again into the state. Redux is not optimized for external state-mutations and has some weird side-effects in that case and sometimes throws an error. This commit fixes the problem by using a clone of the entry. Signed-off-by: Erik Michelson --- .../editor-page/hooks/use-update-local-history-entry.ts | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/frontend/src/components/editor-page/hooks/use-update-local-history-entry.ts b/frontend/src/components/editor-page/hooks/use-update-local-history-entry.ts index ee195474c..a69585eac 100644 --- a/frontend/src/components/editor-page/hooks/use-update-local-history-entry.ts +++ b/frontend/src/components/editor-page/hooks/use-update-local-history-entry.ts @@ -43,10 +43,11 @@ export const useUpdateLocalHistoryEntry = (): void => { if (entry.origin === HistoryEntryOrigin.REMOTE) { return } - entry.title = currentNoteTitle - entry.tags = currentNoteTags - entry.lastVisitedAt = new Date().toISOString() - updateLocalHistoryEntry(id, entry) + const updatedEntry = { ...entry } + updatedEntry.title = currentNoteTitle + updatedEntry.tags = currentNoteTags + updatedEntry.lastVisitedAt = new Date().toISOString() + updateLocalHistoryEntry(id, updatedEntry) lastNoteTitle.current = currentNoteTitle lastNoteTags.current = currentNoteTags }, [id, userExists, currentNoteTitle, currentNoteTags])