From df05bff82a32dc2f535cd72f4624006bdc10f904 Mon Sep 17 00:00:00 2001 From: Sheogorath Date: Wed, 4 Jul 2018 21:08:57 +0200 Subject: [PATCH] ToC: Some HTML improvements and style fixes The ToC generated broken HTML with unclosed `
  • ` tags. This got fixed as well as some minor optimisation and adding list elements for the subentries so the elements appear in the ToC while scrolling. Signed-off-by: Sheogorath --- public/css/extra.css | 4 ++++ public/vendor/md-toc.js | 22 ++++++++++++++++------ 2 files changed, 20 insertions(+), 6 deletions(-) diff --git a/public/css/extra.css b/public/css/extra.css index 1b132901f..3954c046f 100644 --- a/public/css/extra.css +++ b/public/css/extra.css @@ -93,6 +93,10 @@ color: #777; } +.toc .invisable-node { + list-style-type: none; +} + .ui-toc { position: fixed; bottom: 20px; diff --git a/public/vendor/md-toc.js b/public/vendor/md-toc.js index 661f7f855..876978f78 100644 --- a/public/vendor/md-toc.js +++ b/public/vendor/md-toc.js @@ -52,18 +52,17 @@ titleNames = this._elTitlesNames ulClass = this.ulClass } - var titleElementsLen = titleElements.length // No need to do anything for an empty ToC - if (!titleElementsLen) return + if (!titleElements.length) return - this.tocContent = '' var content = '' + elementText + '' // Reset recursion. We need it for the next subsections recurse = false - + openTag = true // Check if the current element has a lower level than ours, if so, we have to go down the rabbithole! } else if (!recurse && titleNames.indexOf(elementTag.toLowerCase()) > level) { recurse = true + if (!openTag) { + content += '
  • ' + openTag = true + } // This element is for the lower lever, we have to re-add it before we send the list down there. titleElements.unshift(element) // Let's call ourself and get to the next level @@ -99,7 +106,10 @@ } } - content += '' + if (openTag) { + content += '
  • \n' + } + content += '\n' // Set ToC content of the level 0 everything else pass things to the upper level! if (level === 0) {