github/hedgedoc
1
0
Fork 0
mirror of https://github.com/hedgedoc/hedgedoc.git synced 2024-11-25 11:16:31 -05:00
Code Issues Projects Releases Packages Wiki Activity

fix(minio): metadata as object not string

Browse source 
A change in the minio JS SDK resulted in uploads being stored
with a defect metadata object in minio, resulting in all
files served as application/octet-stream. This was caused as
the fifth argument to putObject is a metadata object and not
the content-type alone anymore.

Signed-off-by: Erik Michelson <github@erik.michelson.eu>
This commit is contained in:
Erik Michelson 2024-06-19 14:28:23 +02:00
parent c970b1cc48
commit c85b11463d
2 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/web/imageRouter/minio.js
View file

@ -35,7 +35,9 @@ exports.uploadImage = function (imagePath, callback) {
const key = path.join('uploads', path.basename(imagePath)) const key = path.join('uploads', path.basename(imagePath))
const protocol = config.minio.secure ? 'https' : 'http' const protocol = config.minio.secure ? 'https' : 'http'
minioClient.putObject(config.s3bucket, key, buffer, buffer.size, getImageMimeType(imagePath), function (err, data) { minioClient.putObject(config.s3bucket, key, buffer, buffer.size, {
'Content-Type': getImageMimeType(imagePath) || 'application/octet-stream'
}, function (err, data) {
if (err) { if (err) {
callback(new Error(err), null) callback(new Error(err), null)
return return

1
public/docs/release-notes.md
View file

@ -8,6 +8,7 @@
### Bugfixes ### Bugfixes
- Fix a crash when having numeric-only values in opengraph frontmatter - Fix a crash when having numeric-only values in opengraph frontmatter
- Fix unnecessary session creation on healthcheck endpoint - Fix unnecessary session creation on healthcheck endpoint
- Fix defect metadata being sent for minio uploads
## <i class="fa fa-tag"></i> 1.9.9 <i class="fa fa-calendar-o"></i> 2023-07-30 ## <i class="fa fa-tag"></i> 1.9.9 <i class="fa fa-calendar-o"></i> 2023-07-30