github/hedgedoc
1
0
Fork 0
mirror of https://github.com/hedgedoc/hedgedoc.git synced 2024-11-29 00:24:28 -05:00
Code Issues Projects Releases Packages Wiki Activity

fix(image-upload): Fix swallowing of errors for filesystem

Browse source 
This patch fixes the swollowing of the actual error message that appears
when a file fails to move, after being uploaded to Hedgedoc on an
instance that is using the upload-method `filesystem` active.

This became apparent when the error messages provided by some users,
where less than helpful.

As a solution the error message of the copy command was added to the
error that is output to the console.

https://community.hedgedoc.org/t/image-upload-fail-docker/439

Signed-off-by: Sheogorath <sheogorath@shivering-isles.com>
This commit is contained in:
Sheogorath 2021-08-14 19:57:20 +02:00
parent 6c17823da1
commit c025d6abee
No known key found for this signature in database
GPG key ID: C9B1C80737B9CE18
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/web/imageRouter/filesystem.js
View file

@ -22,7 +22,7 @@ exports.uploadImage = function (imagePath, callback) {
try { try {
fs.copyFileSync(imagePath, path.join(config.uploadsPath, fileName)) fs.copyFileSync(imagePath, path.join(config.uploadsPath, fileName))
} catch (e) { } catch (e) {
callback(new Error('Error while moving file'), null) callback(new Error(`Error while moving file: ${e.message}`), null)
return return
} }
callback(null, (new URL(fileName, config.serverURL + '/uploads/')).href) callback(null, (new URL(fileName, config.serverURL + '/uploads/')).href)