From d83e0004b78ec92494e6239821bbc847014926e9 Mon Sep 17 00:00:00 2001 From: Philip Molares Date: Fri, 26 Feb 2021 16:15:46 +0100 Subject: [PATCH 1/3] MediaBackendInterface: Remove getFileURL closes #957 Signed-off-by: Philip Molares --- src/media/media-backend.interface.ts | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/media/media-backend.interface.ts b/src/media/media-backend.interface.ts index 634571392..3c8fd2337 100644 --- a/src/media/media-backend.interface.ts +++ b/src/media/media-backend.interface.ts @@ -16,14 +16,6 @@ export interface MediaBackend { */ saveFile(buffer: Buffer, fileName: string): Promise<[string, BackendData]>; - /** - * Retrieve the URL of a previously saved file. - * @param fileName String to identify the file - * @param backendData Internal backend data - * @throws {MediaBackendError} - there was an error deleting the file - */ - getFileURL(fileName: string, backendData: BackendData): Promise; - /** * Delete a file from the backend * @param fileName String to identify the file From 062104f64b4c4739677f04ed290fa6a60717d347 Mon Sep 17 00:00:00 2001 From: Philip Molares Date: Sat, 27 Feb 2021 11:38:50 +0100 Subject: [PATCH 2/3] FilesystemBackend: Remove getFileURL Signed-off-by: Philip Molares --- src/media/backends/filesystem-backend.ts | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/media/backends/filesystem-backend.ts b/src/media/backends/filesystem-backend.ts index 918fd450b..cefc088c3 100644 --- a/src/media/backends/filesystem-backend.ts +++ b/src/media/backends/filesystem-backend.ts @@ -53,12 +53,6 @@ export class FilesystemBackend implements MediaBackend { } } - getFileURL(fileName: string, _: BackendData): Promise { - const filePath = this.getFilePath(fileName); - // TODO: Add server address to url - return Promise.resolve('/' + filePath); - } - private getFilePath(fileName: string): string { return join(this.uploadDirectory, fileName); } From 7f9c310e5835529e0702efcbc63d6b8d4e9235a3 Mon Sep 17 00:00:00 2001 From: Philip Molares Date: Sat, 27 Feb 2021 12:24:02 +0100 Subject: [PATCH 3/3] MediaBackendInterface: Correct JSDoc of deleteFile Signed-off-by: Philip Molares --- src/media/media-backend.interface.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/media/media-backend.interface.ts b/src/media/media-backend.interface.ts index 3c8fd2337..67337f550 100644 --- a/src/media/media-backend.interface.ts +++ b/src/media/media-backend.interface.ts @@ -20,7 +20,7 @@ export interface MediaBackend { * Delete a file from the backend * @param fileName String to identify the file * @param backendData Internal backend data - * @throws {MediaBackendError} - there was an error retrieving the url + * @throws {MediaBackendError} - there was an error deleting the file */ deleteFile(fileName: string, backendData: BackendData): Promise; }