fix(identity): remove default for syncSource

To make the create method more consistent with the
guidelines,
this commit removes the default value from the `syncSource` parameter.

An Identity will be created as sync source,
when the associated account is created using an external provider.

Signed-off-by: David Mehren <git@herrmehren.de>

src/identity/identity.entity.ts

@@ -100,7 +100,7 @@ export class Identity {
   public static create(
     user: User,
     providerType: ProviderType,
-    syncSource = false,
+    syncSource: boolean,
   ): Omit<Identity, 'id' | 'createdAt' | 'updatedAt'> {
     const newIdentity = new Identity();
     newIdentity.user = user;

src/identity/identity.service.spec.ts

@@ -95,7 +95,11 @@ describe('IdentityService', () => {
 
   describe('loginWithLocalIdentity', () => {
     it('works', async () => {
-      const identity = Identity.create(user, ProviderType.LOCAL) as Identity;
+      const identity = Identity.create(
+        user,
+        ProviderType.LOCAL,
+        false,
+      ) as Identity;
       identity.passwordHash = await hashPassword(password);
       user.identities = Promise.resolve([identity]);
       await expect(

src/identity/identity.service.ts

@@ -36,7 +36,7 @@ export class IdentityService {
    * @return {Identity} the new local identity
    */
   async createLocalIdentity(user: User, password: string): Promise<Identity> {
-    const identity = Identity.create(user, ProviderType.LOCAL);
+    const identity = Identity.create(user, ProviderType.LOCAL, false);
     identity.passwordHash = await hashPassword(password);
     return await this.identityRepository.save(identity);
   }