github/hedgedoc
1
0
Fork 0
mirror of https://github.com/hedgedoc/hedgedoc.git synced 2024-10-22 23:22:08 -04:00
Code Issues Projects Releases Packages Wiki Activity

fix(identity): remove default for syncSource

Browse source 
To make the create method more consistent with the
guidelines,
this commit removes the default value from the `syncSource` parameter.

An Identity will be created as sync source,
when the associated account is created using an external provider.

Signed-off-by: David Mehren <git@herrmehren.de>
This commit is contained in:
David Mehren 2021-11-14 20:56:17 +01:00
parent 5ba6b4ab67
commit a08d8c58ed
No known key found for this signature in database
GPG key ID: 185982BA4C42B7C3
3 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/identity/identity.entity.ts
View file

@ -100,7 +100,7 @@ export class Identity {
public static create( public static create(
user: User, user: User,
providerType: ProviderType, providerType: ProviderType,
syncSource = false, syncSource: boolean,
): Omit<Identity, 'id' | 'createdAt' | 'updatedAt'> { ): Omit<Identity, 'id' | 'createdAt' | 'updatedAt'> {
const newIdentity = new Identity(); const newIdentity = new Identity();
newIdentity.user = user; newIdentity.user = user;

6
src/identity/identity.service.spec.ts
View file

@ -95,7 +95,11 @@ describe('IdentityService', () => {
describe('loginWithLocalIdentity', () => { describe('loginWithLocalIdentity', () => {
it('works', async () => { it('works', async () => {
const identity = Identity.create(user, ProviderType.LOCAL) as Identity; const identity = Identity.create(
user,
ProviderType.LOCAL,
false,
) as Identity;
identity.passwordHash = await hashPassword(password); identity.passwordHash = await hashPassword(password);
user.identities = Promise.resolve([identity]); user.identities = Promise.resolve([identity]);
await expect( await expect(

2
src/identity/identity.service.ts
View file

@ -36,7 +36,7 @@ export class IdentityService {
* @return {Identity} the new local identity * @return {Identity} the new local identity
*/ */
async createLocalIdentity(user: User, password: string): Promise<Identity> { async createLocalIdentity(user: User, password: string): Promise<Identity> {
const identity = Identity.create(user, ProviderType.LOCAL); const identity = Identity.create(user, ProviderType.LOCAL, false);
identity.passwordHash = await hashPassword(password); identity.passwordHash = await hashPassword(password);
return await this.identityRepository.save(identity); return await this.identityRepository.save(identity);
} }