github/hedgedoc
1
0
Fork 0
mirror of https://github.com/hedgedoc/hedgedoc.git synced 2024-10-18 13:20:16 -04:00
Code Issues Projects Releases Packages Wiki Activity

Add missing null in type in permissions service

Browse source 
The parameters of the permission checking methods were missing a null value for not set user. This is the case if user is not logged in and operating as guest.

Signed-off-by: Yannick Bungers <git@innay.de>
This commit is contained in:
Yannick Bungers 2021-11-29 22:42:31 +01:00 committed by David Mehren
parent fdddedf6b3
commit 9093e5fabc
No known key found for this signature in database
GPG key ID: 185982BA4C42B7C3
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/permissions/permissions.service.ts
View file

@ -21,7 +21,7 @@ export enum GuestPermission {
@Injectable()
export class PermissionsService {
public guestPermission: GuestPermission; // TODO change to configOption
mayRead(user: User, note: Note): boolean {
mayRead(user: User | null, note: Note): boolean {
if (this.isOwner(user, note)) return true;
if (this.hasPermissionUser(user, note, false)) return true;
@ -32,7 +32,7 @@ export class PermissionsService {
return false;
}
mayWrite(user: User, note: Note): boolean {
mayWrite(user: User | null, note: Note): boolean {
if (this.isOwner(user, note)) return true;
if (this.hasPermissionUser(user, note, true)) return true;
@ -43,7 +43,7 @@ export class PermissionsService {
return false;
}
mayCreate(user: User): boolean {
mayCreate(user: User | null): boolean {
if (user) {
return true;
} else {
@ -58,14 +58,14 @@ export class PermissionsService {
return false;
}
isOwner(user: User, note: Note): boolean {
isOwner(user: User | null, note: Note): boolean {
if (!user) return false;
if (!note.owner) return false;
return note.owner.id === user.id;
}
private hasPermissionUser(
user: User,
user: User | null,
note: Note,
wantEdit: boolean,
): boolean {
@ -84,7 +84,7 @@ export class PermissionsService {
}
private hasPermissionGroup(
user: User,
user: User | null,
note: Note,
wantEdit: boolean,
): boolean {