From 8fada8809ccd21af85396dae178f1d53d4b926e4 Mon Sep 17 00:00:00 2001 From: David Mehren Date: Sat, 26 Sep 2020 16:00:17 +0200 Subject: [PATCH] UsersService: Merge if-statements and add `null` to return type in `toUserDto` Signed-off-by: David Mehren --- src/users/users.service.ts | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/users/users.service.ts b/src/users/users.service.ts index ccbcea032..88e5fbbf9 100644 --- a/src/users/users.service.ts +++ b/src/users/users.service.ts @@ -26,13 +26,9 @@ export class UsersService { } } - toUserDto(user: User): UserInfoDto { - if (user === undefined) { - this.logger.warn('toUserDto recieved undefined argument!'); - return null; - } - if (user === null) { - this.logger.warn('toUserDto recieved null argument!'); + toUserDto(user: User | null | undefined): UserInfoDto | null { + if (!user) { + this.logger.warn(`toUserDto recieved ${user} argument!`); return null; } return {