github/hedgedoc
1
0
Fork 0
mirror of https://github.com/hedgedoc/hedgedoc.git synced 2024-11-23 18:26:32 -05:00
Code Issues Projects Releases Packages Wiki Activity

FilesystemBackend: Throw MediaBackendError where appropriate

Browse source 
Signed-off-by: Philip Molares <philip.molares@udo.edu>
This commit is contained in:
Philip Molares 2021-02-25 13:52:50 +01:00
parent bee2333f77
commit 8365132a39
1 changed files with 26 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
src/media/backends/filesystem-backend.ts
View file

@ -12,6 +12,7 @@ import { ConsoleLoggerService } from '../../logger/console-logger.service';
import { MediaBackend } from '../media-backend.interface'; import { MediaBackend } from '../media-backend.interface';
import { BackendData } from '../media-upload.entity'; import { BackendData } from '../media-upload.entity';
import { MediaConfig } from '../../config/media.config'; import { MediaConfig } from '../../config/media.config';
import { MediaBackendError } from '../../errors/errors';
@Injectable() @Injectable()
export class FilesystemBackend implements MediaBackend { export class FilesystemBackend implements MediaBackend {
@ -33,12 +34,23 @@ export class FilesystemBackend implements MediaBackend {
const filePath = this.getFilePath(fileName); const filePath = this.getFilePath(fileName);
this.logger.debug(`Writing file to: ${filePath}`, 'saveFile'); this.logger.debug(`Writing file to: ${filePath}`, 'saveFile');
await this.ensureDirectory(); await this.ensureDirectory();
try {
await fs.writeFile(filePath, buffer, null); await fs.writeFile(filePath, buffer, null);
return ['/' + filePath, null]; return ['/' + filePath, null];
} catch (e) {
this.logger.error(e.message, e.stack, 'saveFile');
throw new MediaBackendError(`Could not save '${filePath}'`);
}
} }
async deleteFile(fileName: string, _: BackendData): Promise<void> { async deleteFile(fileName: string, _: BackendData): Promise<void> {
return fs.unlink(this.getFilePath(fileName)); const filePath = this.getFilePath(fileName);
try {
return fs.unlink(filePath);
} catch (e) {
this.logger.error(e.message, e.stack, 'deleteFile');
throw new MediaBackendError(`Could not delete '${filePath}'`);
}
} }
getFileURL(fileName: string, _: BackendData): Promise<string> { getFileURL(fileName: string, _: BackendData): Promise<string> {
@ -55,7 +67,17 @@ export class FilesystemBackend implements MediaBackend {
try { try {
await fs.access(this.uploadDirectory); await fs.access(this.uploadDirectory);
} catch (e) { } catch (e) {
try {
this.logger.debug(
`The directory '${this.uploadDirectory}' can't be accessed. Trying to create the directory`,
);
await fs.mkdir(this.uploadDirectory); await fs.mkdir(this.uploadDirectory);
} catch (e) {
this.logger.error(e.message, e.stack, 'deleteFile');
throw new MediaBackendError(
`Could not create '${this.uploadDirectory}'`,
);
}
} }
} }
} }