github/hedgedoc
1
0
Fork 0
mirror of https://github.com/hedgedoc/hedgedoc.git synced 2024-10-19 22:00:15 -04:00
Code Issues Projects Releases Packages Wiki Activity

AuthTokenDto: Make properties consistently optional

Browse source 
validUntil and lastUsed already have a IsOptional decorator,
this makes the properties themselves also optional

Signed-off-by: David Mehren <git@herrmehren.de>
This commit is contained in:
David Mehren 2021-04-29 15:55:11 +02:00
parent cfaa07806b
commit 72b545fec5
No known key found for this signature in database
GPG key ID: 185982BA4C42B7C3
3 changed files with 4 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/auth/auth-token.dto.ts
View file

@ -15,8 +15,8 @@ export class AuthTokenDto {
createdAt: Date; createdAt: Date;
@IsDate() @IsDate()
@IsOptional() @IsOptional()
validUntil: Date; validUntil: Date | null;
@IsDate() @IsDate()
@IsOptional() @IsOptional()
lastUsed: Date; lastUsed: Date | null;
} }

4
src/auth/auth.service.spec.ts
View file

@ -251,7 +251,7 @@ describe('AuthService', () => {
}); });
jest.spyOn(authTokenRepo, 'save').mockImplementationOnce( jest.spyOn(authTokenRepo, 'save').mockImplementationOnce(
async (authTokenSaved: AuthToken, _): Promise<AuthToken> => { async (authTokenSaved: AuthToken, _): Promise<AuthToken> => {
expect(authTokenSaved.lastUsed).toBeUndefined(); expect(authTokenSaved.lastUsed).toBeNull();
return authTokenSaved; return authTokenSaved;
}, },
); );
@ -275,7 +275,7 @@ describe('AuthService', () => {
}); });
jest.spyOn(authTokenRepo, 'save').mockImplementationOnce( jest.spyOn(authTokenRepo, 'save').mockImplementationOnce(
async (authTokenSaved: AuthToken, _): Promise<AuthToken> => { async (authTokenSaved: AuthToken, _): Promise<AuthToken> => {
expect(authTokenSaved.lastUsed).toBeUndefined(); expect(authTokenSaved.lastUsed).toBeNull();
return authTokenSaved; return authTokenSaved;
}, },
); );

2
src/auth/auth.service.ts
View file

@ -181,8 +181,6 @@ export class AuthService {
toAuthTokenDto(authToken: AuthToken): AuthTokenDto { toAuthTokenDto(authToken: AuthToken): AuthTokenDto {
const tokenDto: AuthTokenDto = { const tokenDto: AuthTokenDto = {
lastUsed: null,
validUntil: null,
label: authToken.label, label: authToken.label,
keyId: authToken.keyId, keyId: authToken.keyId,
createdAt: authToken.createdAt, createdAt: authToken.createdAt,