fix: remove redundant redirect code

Signed-off-by: Tilman Vatteroth <git@tilmanvatteroth.de>
This commit is contained in:
Tilman Vatteroth 2022-08-14 20:56:02 +02:00
parent f7a51cd406
commit 6e103a856e

View file

@ -1,11 +1,11 @@
/* /*
* SPDX-FileCopyrightText: 2021 The HedgeDoc developers (see AUTHORS file) * SPDX-FileCopyrightText: 2022 The HedgeDoc developers (see AUTHORS file)
* *
* SPDX-License-Identifier: AGPL-3.0-only * SPDX-License-Identifier: AGPL-3.0-only
*/ */
import type { FormEvent } from 'react' import type { FormEvent } from 'react'
import React, { useCallback, useEffect, useMemo, useState } from 'react' import React, { useCallback, useMemo, useState } from 'react'
import { Button, Card, Col, Form, Row } from 'react-bootstrap' import { Button, Card, Col, Form, Row } from 'react-bootstrap'
import { Trans, useTranslation } from 'react-i18next' import { Trans, useTranslation } from 'react-i18next'
import { doLocalRegister } from '../api/auth/local' import { doLocalRegister } from '../api/auth/local'
@ -20,13 +20,9 @@ import { PasswordAgainField } from '../components/common/fields/password-again-f
import { useOnInputChange } from '../hooks/common/use-on-input-change' import { useOnInputChange } from '../hooks/common/use-on-input-change'
import { RegisterError } from '../components/register-page/register-error/register-error' import { RegisterError } from '../components/register-page/register-error/register-error'
import { LandingLayout } from '../components/landing-layout/landing-layout' import { LandingLayout } from '../components/landing-layout/landing-layout'
import { useRouter } from 'next/router'
import type { NextPage } from 'next' import type { NextPage } from 'next'
import { Logger } from '../utils/logger'
import { Redirect } from '../components/common/redirect' import { Redirect } from '../components/common/redirect'
const logger = new Logger('register-page')
/** /**
* Renders the registration page with fields for username, display name, password, password retype and information about terms and conditions. * Renders the registration page with fields for username, display name, password, password retype and information about terms and conditions.
*/ */
@ -72,15 +68,6 @@ export const RegisterPage: NextPage = () => {
const onPasswordChange = useOnInputChange(setPassword) const onPasswordChange = useOnInputChange(setPassword)
const onPasswordAgainChange = useOnInputChange(setPasswordAgain) const onPasswordAgainChange = useOnInputChange(setPasswordAgain)
const router = useRouter()
useEffect(() => {
if (!allowRegister) {
router.push('/login').catch((reason) => logger.error('Error while redirecting to /login', reason))
} else if (userExists) {
router.push('/intro').catch((reason) => logger.error('Error while redirecting to /intro', reason))
}
}, [allowRegister, router, userExists])
if (userExists) { if (userExists) {
return <Redirect to={'/intro'} /> return <Redirect to={'/intro'} />
} }