Refactor server version object into own interface

This makes the type of getServerVersionFromPackageJson() way easier
to read.

Signed-off-by: David Mehren <git@herrmehren.de>

src/monitoring/monitoring.service.ts

@@ -5,24 +5,13 @@
  */
 
 import { Injectable } from '@nestjs/common';
-import { ServerStatusDto } from './server-status.dto';
 import { promises as fs } from 'fs';
 import { join as joinPath } from 'path';
+import { ServerStatusDto, ServerVersion } from './server-status.dto';
 
-let versionCache: null | {
+let versionCache: ServerVersion;
-  major: number;
+
-  minor: number;
+async function getServerVersionFromPackageJson(): Promise<ServerVersion> {
-  patch: number;
-  preRelease?: string;
-  commit?: string;
-} = null;
-async function getServerVersionFromPackageJson(): Promise<{
-  major: number;
-  minor: number;
-  patch: number;
-  preRelease?: string;
-  commit?: string;
-}> {
   if (versionCache === null) {
     const rawFileContent: string = await fs.readFile(
       joinPath(__dirname, '../../package.json'),

src/monitoring/server-status.dto.ts

@@ -4,14 +4,16 @@
  * SPDX-License-Identifier: AGPL-3.0-only
  */
 
+export interface ServerVersion {
+  major: number;
+  minor: number;
+  patch: number;
+  preRelease?: string;
+  commit?: string;
+}
+
 export class ServerStatusDto {
-  serverVersion: {
+  serverVersion: ServerVersion;
-    major: number;
-    minor: number;
-    patch: number;
-    preRelease?: string;
-    commit?: string;
-  };
   onlineNotes: number;
   onlineUsers: number;
   destictOnlineUsers: number;