fix: check for existent notes on POST

Signed-off-by: Erik Michelson <github@erik.michelson.eu>

lib/web/note/util.js

@@ -2,6 +2,7 @@ const models = require('../../models')
 const logger = require('../../logger')
 const config = require('../../config')
 const errors = require('../../errors')
+const { Op } = require('sequelize')
 const fs = require('fs')
 const path = require('path')
 
@@ -48,7 +49,14 @@ exports.checkViewPermission = function (req, note) {
 
 exports.newNote = async function (req, res, body) {
   let owner = null
+  let decodedNoteId
   const noteId = req.params.noteId ? req.params.noteId : null
+  try {
+    decodedNoteId = models.Note.decodeNoteId(noteId)
+  } catch (error) {
+    decodedNoteId = ''
+  }
+
   if (req.isAuthenticated()) {
     owner = req.user.id
   } else if (!config.allowAnonymous) {
@@ -62,17 +70,24 @@ exports.newNote = async function (req, res, body) {
     }
 
     try {
-      const id = await new Promise((resolve, reject) => {
+      const possibleFilePath = path.join(config.docsPath, path.basename(noteId) + '.md')
-        models.Note.parseNoteId(noteId, (err, id) => {
+      const noteFileExists = await models.Note.checkFileExist(possibleFilePath)
-          if (err) {
+      const count = await models.Note.count({
-            reject(err)
+        where: {
-          } else {
+          [Op.or]: [
-            resolve(id)
+            {
-          }
+              alias: req.alias
-        })
+            },
+            {
+              id: decodedNoteId
+            },
+            {
+              shortId: req.alias
+            }
+          ]
+        }
       })
-
+      if (count > 0 || noteFileExists) {
-      if (id) {
         return errors.errorConflict(res)
       }
     } catch (error) {