refactor: move error messages from controller to service

Signed-off-by: Philip Molares <philip.molares@udo.edu>

src/api/private/auth/auth.controller.ts

@@ -75,7 +75,6 @@ export class AuthController {
     @RequestUser() user: User,
     @Body() changePasswordDto: UpdatePasswordDto,
   ): Promise<void> {
-    try {
     await this.identityService.checkLocalPassword(
       user,
       changePasswordDto.currentPassword,
@@ -85,15 +84,6 @@ export class AuthController {
       changePasswordDto.newPassword,
     );
     return;
-    } catch (e) {
-      if (e instanceof InvalidCredentialsError) {
-        throw new UnauthorizedException('Password is not correct');
-      }
-      if (e instanceof NoLocalIdentityError) {
-        throw new BadRequestException('User has no local identity.');
-      }
-      throw e;
-    }
   }
 
   @UseGuards(LoginEnabledGuard, LocalAuthGuard)

src/identity/identity.service.ts

@@ -85,14 +85,14 @@ export class IdentityService {
         `The user with the username ${user.username} does not have a internal identity.`,
         'checkLocalPassword',
       );
-      throw new NoLocalIdentityError();
+      throw new NoLocalIdentityError('This user has no internal identity.');
     }
     if (!(await checkPassword(password, internalIdentity.passwordHash ?? ''))) {
       this.logger.debug(
         `Password check for ${user.username} did not succeed.`,
         'checkLocalPassword',
       );
-      throw new InvalidCredentialsError();
+      throw new InvalidCredentialsError('Password is not correct');
     }
   }
 }