github/hedgedoc
1
0
Fork 0
mirror of https://github.com/hedgedoc/hedgedoc.git synced 2024-11-23 02:06:29 -05:00
Code Issues Projects Releases Packages Wiki Activity

fix(frontend): simplify asciinema regex

Browse source 
Signed-off-by: Tilman Vatteroth <git@tilmanvatteroth.de>
This commit is contained in:
Tilman Vatteroth 2023-02-06 12:11:51 +01:00
parent 215ceea72c
commit 3f8771a15e
2 changed files with 7 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
frontend/src/extensions/extra-integrations/asciinema/replace-asciinema-link.test.ts
View file

@ -25,6 +25,12 @@ describe('Replace asciinema link', () => {
) )
}) })
it('will replace a valid URL with appendix', () => {
expect(markdownIt.renderInline('https://asciinema.org/a/123981234?a=1')).toBe(
`<app-asciinema id='123981234'></app-asciinema>`
)
})
it("won't replace an URL without path", () => { it("won't replace an URL without path", () => {
expect(markdownIt.renderInline('https://asciinema.org/123981234')).toBe(`https://asciinema.org/123981234`) expect(markdownIt.renderInline('https://asciinema.org/123981234')).toBe(`https://asciinema.org/123981234`)
}) })

9
frontend/src/extensions/extra-integrations/asciinema/replace-asciinema-link.ts
View file

@ -8,14 +8,7 @@ import { AsciinemaMarkdownExtension } from './asciinema-markdown-extension'
import type MarkdownIt from 'markdown-it' import type MarkdownIt from 'markdown-it'
import markdownItRegex from 'markdown-it-regex' import markdownItRegex from 'markdown-it-regex'
const protocolRegex = /(?:http(?:s)?:\/\/)?/ const asciinemaUrlRegex = /^https?:\/\/asciinema\.org\/a\/(\d+)(?:\?.*)?$/i
const domainRegex = /(?:asciinema\.org\/a\/)/
const idRegex = /(\d+)/
const tailRegex = /(?:[./?#].*)?/
const asciinemaUrlRegex = new RegExp(
`^(?:${protocolRegex.source}${domainRegex.source}${idRegex.source}${tailRegex.source})$`,
'i'
)
const replaceAsciinemaLink: RegexOptions = { const replaceAsciinemaLink: RegexOptions = {
name: 'asciinema-link', name: 'asciinema-link',