github/hedgedoc
1
0
Fork 0
mirror of https://github.com/hedgedoc/hedgedoc.git synced 2024-12-04 21:13:33 -05:00
Code Issues Projects Releases Packages Wiki Activity

Update Nginx reverse proxy config example

Browse source 
Omitting trailing slashes in Nginx' `proxy_pass` directives causes redirect loops (see #1024), while the "issue" described in the warning is caused by an incorrect URL.

Fixes: 74b573e

Signed-off-by: Sven Frotscher <67124493+sven-frotscher@users.noreply.github.com>
This commit is contained in:
Sven Frotscher 2024-04-04 11:18:04 +02:00 committed by GitHub
parent c8618fe0a3
commit 3330fed78f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
docs/content/guides/reverse-proxy.md
View file

@ -64,7 +64,7 @@ server {
server_name hedgedoc.example.com; server_name hedgedoc.example.com;
location / { location / {
proxy_pass http://127.0.0.1:3000; proxy_pass http://127.0.0.1:3000/;
proxy_set_header Host $host; proxy_set_header Host $host;
proxy_set_header X-Real-IP $remote_addr; proxy_set_header X-Real-IP $remote_addr;
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for; proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
@ -72,7 +72,7 @@ server {
} }
location /socket.io/ { location /socket.io/ {
proxy_pass http://127.0.0.1:3000; proxy_pass http://127.0.0.1:3000/socket.io/;
proxy_set_header Host $host; proxy_set_header Host $host;
proxy_set_header X-Real-IP $remote_addr; proxy_set_header X-Real-IP $remote_addr;
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for; proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
@ -92,10 +92,11 @@ server {
!!! warning !!! warning
NGINX `proxy_pass` directives must NOT have trailing slashes. If the trailing NGINX `proxy_pass` directives must have trailing slashes. If the trailing
slashes are present, the browser will not be able to establish a WebSocket slashes are not present, clients will get stuck in a redirect loop.
connection to the server, and the editor interface will display an endless loading If `/socket.io/` is not present in the second `proxy_pass` line, the
animation. browser will not be able to establish a WebSocket connection to the server,
and the editor interface will display an endless loading animation.
### Apache ### Apache
You will need these modules enabled: `proxy`, `proxy_http` and `proxy_wstunnel`. You will need these modules enabled: `proxy`, `proxy_http` and `proxy_wstunnel`.