github/hedgedoc
1
0
Fork 0
mirror of https://github.com/hedgedoc/hedgedoc.git synced 2024-11-23 18:26:32 -05:00
Code Issues Projects Releases Packages Wiki Activity

Fix generateAvatarURL

Browse source 
Previously, we checked for `typeof email !== 'string'`. This code got turned into `email.length === 0`, which changed the behaviour of the method.
Because TypeScript makes sure that `email` is always a string, we can get rid of the check altogether.

Signed-off-by: David Mehren <dmehren1@gmail.com>
This commit is contained in:
David Mehren 2020-05-16 17:49:59 +02:00
parent 08655f06f9
commit 3262315248
No known key found for this signature in database
GPG key ID: 6017AF117F9756CB
1 changed files with 0 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
lib/letter-avatars.ts
View file

@ -25,9 +25,6 @@ export function generateAvatar (name: string): string {
export function generateAvatarURL (name: string, email = '', big = true): string { export function generateAvatarURL (name: string, email = '', big = true): string {
let photo let photo
if (email.length === 0) {
email = '' + name + '@example.com'
}
name = encodeURIComponent(name) name = encodeURIComponent(name)
const hash = createHash('md5') const hash = createHash('md5')