From 23901d145458f59971e466b0a8d46f8d257ad585 Mon Sep 17 00:00:00 2001 From: Tilman Vatteroth Date: Tue, 9 May 2023 11:38:02 +0200 Subject: [PATCH] chore: change recommended and CI node version to v20 Signed-off-by: Tilman Vatteroth --- .github/workflows/e2e-tests.yml | 2 +- .github/workflows/frontend-netlify-deploy-main.yml | 2 +- .github/workflows/frontend-netlify-deploy-pr.yml | 2 +- .github/workflows/lint.yml | 2 +- .github/workflows/test-and-build.yml | 4 ++-- backend/package.json | 2 +- docs/content/dev/getting-started.md | 2 +- frontend/package.json | 2 +- yarn.lock | 12 ++++++------ 9 files changed, 15 insertions(+), 15 deletions(-) diff --git a/.github/workflows/e2e-tests.yml b/.github/workflows/e2e-tests.yml index 7859e7cd5..4e7896010 100644 --- a/.github/workflows/e2e-tests.yml +++ b/.github/workflows/e2e-tests.yml @@ -20,7 +20,7 @@ concurrency: cancel-in-progress: true env: - NODEJS_VERSION: 18 + NODEJS_VERSION: 20 HEAD_COMMIT_HASH: "${{ !!github.event.pull_request && github.event.pull_request.head.sha || github.sha }}" jobs: diff --git a/.github/workflows/frontend-netlify-deploy-main.yml b/.github/workflows/frontend-netlify-deploy-main.yml index 015763779..9f6f271d6 100644 --- a/.github/workflows/frontend-netlify-deploy-main.yml +++ b/.github/workflows/frontend-netlify-deploy-main.yml @@ -11,7 +11,7 @@ on: env: NETLIFY_VERSION: 13.2.2 NETLIFY_NEXTJS_PLUGIN_VERSION: 4.33.0 - NODEJS_VERSION: 18 + NODEJS_VERSION: 20 defaults: run: diff --git a/.github/workflows/frontend-netlify-deploy-pr.yml b/.github/workflows/frontend-netlify-deploy-pr.yml index b8f37ab49..0db652fc6 100644 --- a/.github/workflows/frontend-netlify-deploy-pr.yml +++ b/.github/workflows/frontend-netlify-deploy-pr.yml @@ -29,7 +29,7 @@ permissions: env: NETLIFY_VERSION: 13.2.2 NETLIFY_NEXTJS_PLUGIN_VERSION: 4.33.0 - NODEJS_VERSION: 18 + NODEJS_VERSION: 20 defaults: run: diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index fb29e9911..bb6991314 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -11,7 +11,7 @@ on: branches: [ develop ] env: - NODEJS_VERSION: 18 + NODEJS_VERSION: 20 jobs: lint: diff --git a/.github/workflows/test-and-build.yml b/.github/workflows/test-and-build.yml index 2cc51057e..cc8a50846 100644 --- a/.github/workflows/test-and-build.yml +++ b/.github/workflows/test-and-build.yml @@ -19,9 +19,9 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - node: [ '16', '18' ] # Are you changing this? Don't forget to update the min. and recommended node version in getting-started.md! + node: [ '16', '18', '20' ] # Are you changing this? Don't forget to update the min. and recommended node version in getting-started.md! include: - - node: '18' + - node: '20' coverage: true name: Test and build with NodeJS ${{ matrix.node }} steps: diff --git a/backend/package.json b/backend/package.json index 95011d089..a8cc29800 100644 --- a/backend/package.json +++ b/backend/package.json @@ -90,7 +90,7 @@ "@types/express-session": "1.17.7", "@types/jest": "29.5.1", "@types/mysql": "2.15.21", - "@types/node": "18.16.6", + "@types/node": "20.1.1", "@types/passport-local": "1.0.35", "@types/pg": "8.6.6", "@types/source-map-support": "0.5.6", diff --git a/docs/content/dev/getting-started.md b/docs/content/dev/getting-started.md index 495045f14..86cc903f1 100644 --- a/docs/content/dev/getting-started.md +++ b/docs/content/dev/getting-started.md @@ -19,7 +19,7 @@ recommend caddy and the provided configuration. git clone https://github.com/hedgedoc/hedgedoc.git cd hedgedoc ``` -2. Install Node.js. You need at least Node 16, but we recommend Node 18. +2. Install Node.js. You need at least Node 16, but we recommend Node 20. 3. Install [Yarn](https://yarnpkg.com/getting-started/install) 4. Install Caddy (select one of the two options) - [Download](https://caddyserver.com/) and place the `caddy` binary in `dev-reverse-proxy`. Ensure it is executable with `chmod +x caddy`. Users of macOS may need to run `xattr -d com.apple.quarantine ./caddy` to lift the quarantine for executables from the internet. diff --git a/frontend/package.json b/frontend/package.json index 9cb02ae29..0e20661da 100644 --- a/frontend/package.json +++ b/frontend/package.json @@ -139,7 +139,7 @@ "@types/markdown-it": "12.2.3", "@types/markdown-it-container": "2.0.5", "@types/markdown-it-plantuml": "1.4.1", - "@types/node": "18.16.6", + "@types/node": "20.1.1", "@types/react": "18.2.6", "@types/react-dom": "18.2.4", "@types/sass": "1.43.1", diff --git a/yarn.lock b/yarn.lock index 1b8674752..88c0dafdf 100644 --- a/yarn.lock +++ b/yarn.lock @@ -2273,7 +2273,7 @@ __metadata: "@types/jest": 29.5.1 "@types/minio": 7.0.18 "@types/mysql": 2.15.21 - "@types/node": 18.16.6 + "@types/node": 20.1.1 "@types/node-fetch": 2.6.3 "@types/passport-http-bearer": 1.0.37 "@types/passport-local": 1.0.35 @@ -2406,7 +2406,7 @@ __metadata: "@types/markdown-it": 12.2.3 "@types/markdown-it-container": 2.0.5 "@types/markdown-it-plantuml": 1.4.1 - "@types/node": 18.16.6 + "@types/node": 20.1.1 "@types/react": 18.2.6 "@types/react-dom": 18.2.4 "@types/sass": 1.43.1 @@ -4786,10 +4786,10 @@ __metadata: languageName: node linkType: hard -"@types/node@npm:18.16.6": - version: 18.16.6 - resolution: "@types/node@npm:18.16.6" - checksum: 99417418952c0b1a6ff5dd40ccf01c2cd18db6a1c54bfaaff29c700c877e2e541aa31ea33090592f3817adb2b8c0946b86c7fb57049131e7c08252d70075f09b +"@types/node@npm:20.1.1": + version: 20.1.1 + resolution: "@types/node@npm:20.1.1" + checksum: 47961ee23f873c14c3f6045422ff3059f3bfb10231ef3080a7a72d7215cc8c2623fa8cedb7b246305962fa9c1e0c9e381e04b12eb3e9ec5d076025c6231ac8da languageName: node linkType: hard