github/hedgedoc
1
0
Fork 0
mirror of https://github.com/hedgedoc/hedgedoc.git synced 2024-11-29 17:34:28 -05:00
Code Issues Projects Releases Packages Wiki Activity

Migrate public notes API E2E test to global TestSetup

Browse source 
Signed-off-by: David Mehren <git@herrmehren.de>
This commit is contained in:
David Mehren 2021-10-14 20:52:57 +02:00
parent 386098ed2b
commit 21f4ffe2df
No known key found for this signature in database
GPG key ID: 185982BA4C42B7C3
2 changed files with 152 additions and 120 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

262
test/public-api/notes.e2e-spec.ts
View file

@ -3,36 +3,17 @@
* *
* SPDX-License-Identifier: AGPL-3.0-only * SPDX-License-Identifier: AGPL-3.0-only
*/ */
import { INestApplication } from '@nestjs/common';
import { ConfigModule, ConfigService } from '@nestjs/config';
import { Test } from '@nestjs/testing';
import { TypeOrmModule } from '@nestjs/typeorm';
import { promises as fs } from 'fs'; import { promises as fs } from 'fs';
import { join } from 'path'; import { join } from 'path';
import request from 'supertest'; import request from 'supertest';
import { PublicApiModule } from '../../src/api/public/public-api.module';
import { AuthModule } from '../../src/auth/auth.module';
import { MockAuthGuard } from '../../src/auth/mock-auth.guard';
import { TokenAuthGuard } from '../../src/auth/token.strategy';
import appConfigMock from '../../src/config/mock/app.config.mock';
import mediaConfigMock from '../../src/config/mock/media.config.mock';
import { NotInDBError } from '../../src/errors/errors'; import { NotInDBError } from '../../src/errors/errors';
import { GroupsModule } from '../../src/groups/groups.module';
import { LoggerModule } from '../../src/logger/logger.module';
import { MediaService } from '../../src/media/media.service';
import { NotePermissionsUpdateDto } from '../../src/notes/note-permissions.dto'; import { NotePermissionsUpdateDto } from '../../src/notes/note-permissions.dto';
import { NotesModule } from '../../src/notes/notes.module';
import { NotesService } from '../../src/notes/notes.service';
import { PermissionsModule } from '../../src/permissions/permissions.module';
import { User } from '../../src/users/user.entity'; import { User } from '../../src/users/user.entity';
import { UsersModule } from '../../src/users/users.module'; import { TestSetup } from '../test-setup';
import { UsersService } from '../../src/users/users.service';
describe('Notes', () => { describe('Notes', () => {
let app: INestApplication; let testSetup: TestSetup;
let notesService: NotesService;
let mediaService: MediaService;
let user: User; let user: User;
let user2: User; let user2: User;
let content: string; let content: string;
@ -41,48 +22,26 @@ describe('Notes', () => {
let testImage: Buffer; let testImage: Buffer;
beforeAll(async () => { beforeAll(async () => {
const moduleRef = await Test.createTestingModule({ testSetup = await TestSetup.create();
imports: [
ConfigModule.forRoot({
isGlobal: true,
load: [mediaConfigMock, appConfigMock],
}),
PublicApiModule,
NotesModule,
PermissionsModule,
GroupsModule,
TypeOrmModule.forRoot({
type: 'sqlite',
database: './hedgedoc-e2e-notes.sqlite',
autoLoadEntities: true,
synchronize: true,
dropSchema: true,
}),
LoggerModule,
AuthModule,
UsersModule,
],
})
.overrideGuard(TokenAuthGuard)
.useClass(MockAuthGuard)
.compile();
const config = moduleRef.get<ConfigService>(ConfigService); forbiddenNoteId =
forbiddenNoteId = config.get('appConfig').forbiddenNoteIds[0]; testSetup.configService.get('appConfig').forbiddenNoteIds[0];
uploadPath = config.get('mediaConfig').backend.filesystem.uploadPath; uploadPath =
app = moduleRef.createNestApplication(); testSetup.configService.get('mediaConfig').backend.filesystem.uploadPath;
await app.init();
notesService = moduleRef.get(NotesService); await testSetup.app.init();
mediaService = moduleRef.get(MediaService);
const userService = moduleRef.get(UsersService); user = await testSetup.userService.createUser('hardcoded', 'Testy');
user = await userService.createUser('hardcoded', 'Testy'); user2 = await testSetup.userService.createUser(
user2 = await userService.createUser('hardcoded2', 'Max Mustermann'); 'hardcoded2',
'Max Mustermann',
);
content = 'This is a test note.'; content = 'This is a test note.';
testImage = await fs.readFile('test/public-api/fixtures/test.png'); testImage = await fs.readFile('test/public-api/fixtures/test.png');
}); });
it('POST /notes', async () => { it('POST /notes', async () => {
const response = await request(app.getHttpServer()) const response = await request(testSetup.app.getHttpServer())
.post('/notes') .post('/notes')
.set('Content-Type', 'text/markdown') .set('Content-Type', 'text/markdown')
.send(content) .send(content)
@ -90,8 +49,10 @@ describe('Notes', () => {
.expect(201); .expect(201);
expect(response.body.metadata?.id).toBeDefined(); expect(response.body.metadata?.id).toBeDefined();
expect( expect(
await notesService.getNoteContent( await testSetup.notesService.getNoteContent(
await notesService.getNoteByIdOrAlias(response.body.metadata.id), await testSetup.notesService.getNoteByIdOrAlias(
response.body.metadata.id,
),
), ),
).toEqual(content); ).toEqual(content);
}); });
@ -99,8 +60,8 @@ describe('Notes', () => {
describe('GET /notes/{note}', () => { describe('GET /notes/{note}', () => {
it('works with an existing note', async () => { it('works with an existing note', async () => {
// check if we can succefully get a note that exists // check if we can succefully get a note that exists
await notesService.createNote(content, 'test1', user); await testSetup.notesService.createNote(content, 'test1', user);
const response = await request(app.getHttpServer()) const response = await request(testSetup.app.getHttpServer())
.get('/notes/test1') .get('/notes/test1')
.expect('Content-Type', /json/) .expect('Content-Type', /json/)
.expect(200); .expect(200);
@ -108,14 +69,14 @@ describe('Notes', () => {
}); });
it('fails with an non-existing note', async () => { it('fails with an non-existing note', async () => {
// check if a missing note correctly returns 404 // check if a missing note correctly returns 404
await request(app.getHttpServer()) await request(testSetup.app.getHttpServer())
.get('/notes/i_dont_exist') .get('/notes/i_dont_exist')
.expect('Content-Type', /json/) .expect('Content-Type', /json/)
.expect(404); .expect(404);
}); });
it('fails with a forbidden note id', async () => { it('fails with a forbidden note id', async () => {
// check if a forbidden note correctly returns 400 // check if a forbidden note correctly returns 400
await request(app.getHttpServer()) await request(testSetup.app.getHttpServer())
.get('/notes/forbiddenNoteId') .get('/notes/forbiddenNoteId')
.expect('Content-Type', /json/) .expect('Content-Type', /json/)
.expect(400); .expect(400);
@ -124,7 +85,7 @@ describe('Notes', () => {
describe('POST /notes/{note}', () => { describe('POST /notes/{note}', () => {
it('works with a non-existing alias', async () => { it('works with a non-existing alias', async () => {
const response = await request(app.getHttpServer()) const response = await request(testSetup.app.getHttpServer())
.post('/notes/test2') .post('/notes/test2')
.set('Content-Type', 'text/markdown') .set('Content-Type', 'text/markdown')
.send(content) .send(content)
@ -132,14 +93,16 @@ describe('Notes', () => {
.expect(201); .expect(201);
expect(response.body.metadata?.id).toBeDefined(); expect(response.body.metadata?.id).toBeDefined();
return expect( return expect(
await notesService.getNoteContent( await testSetup.notesService.getNoteContent(
await notesService.getNoteByIdOrAlias(response.body.metadata?.id), await testSetup.notesService.getNoteByIdOrAlias(
response.body.metadata?.id,
),
), ),
).toEqual(content); ).toEqual(content);
}); });
it('fails with a forbidden alias', async () => { it('fails with a forbidden alias', async () => {
await request(app.getHttpServer()) await request(testSetup.app.getHttpServer())
.post(`/notes/${forbiddenNoteId}`) .post(`/notes/${forbiddenNoteId}`)
.set('Content-Type', 'text/markdown') .set('Content-Type', 'text/markdown')
.send(content) .send(content)
@ -148,7 +111,7 @@ describe('Notes', () => {
}); });
it('fails with a existing alias', async () => { it('fails with a existing alias', async () => {
await request(app.getHttpServer()) await request(testSetup.app.getHttpServer())
.post('/notes/test2') .post('/notes/test2')
.set('Content-Type', 'text/markdown') .set('Content-Type', 'text/markdown')
.send(content) .send(content)
@ -161,35 +124,55 @@ describe('Notes', () => {
describe('works', () => { describe('works', () => {
it('with an existing alias and keepMedia false', async () => { it('with an existing alias and keepMedia false', async () => {
const noteId = 'test3'; const noteId = 'test3';
const note = await notesService.createNote(content, noteId, user); const note = await testSetup.notesService.createNote(
await mediaService.saveFile(testImage, user, note); content,
await request(app.getHttpServer()) noteId,
user,
);
await testSetup.mediaService.saveFile(testImage, user, note);
await request(testSetup.app.getHttpServer())
.delete(`/notes/${noteId}`) .delete(`/notes/${noteId}`)
.set('Content-Type', 'application/json') .set('Content-Type', 'application/json')
.send({ .send({
keepMedia: false, keepMedia: false,
}) })
.expect(204); .expect(204);
await expect(notesService.getNoteByIdOrAlias(noteId)).rejects.toEqual( await expect(
testSetup.notesService.getNoteByIdOrAlias(noteId),
).rejects.toEqual(
new NotInDBError(`Note with id/alias '${noteId}' not found.`), new NotInDBError(`Note with id/alias '${noteId}' not found.`),
); );
expect(await mediaService.listUploadsByUser(user)).toHaveLength(0); expect(
await testSetup.mediaService.listUploadsByUser(user),
).toHaveLength(0);
}); });
it('with an existing alias and keepMedia true', async () => { it('with an existing alias and keepMedia true', async () => {
const noteId = 'test3a'; const noteId = 'test3a';
const note = await notesService.createNote(content, noteId, user); const note = await testSetup.notesService.createNote(
const url = await mediaService.saveFile(testImage, user, note); content,
await request(app.getHttpServer()) noteId,
user,
);
const url = await testSetup.mediaService.saveFile(
testImage,
user,
note,
);
await request(testSetup.app.getHttpServer())
.delete(`/notes/${noteId}`) .delete(`/notes/${noteId}`)
.set('Content-Type', 'application/json') .set('Content-Type', 'application/json')
.send({ .send({
keepMedia: true, keepMedia: true,
}) })
.expect(204); .expect(204);
await expect(notesService.getNoteByIdOrAlias(noteId)).rejects.toEqual( await expect(
testSetup.notesService.getNoteByIdOrAlias(noteId),
).rejects.toEqual(
new NotInDBError(`Note with id/alias '${noteId}' not found.`), new NotInDBError(`Note with id/alias '${noteId}' not found.`),
); );
expect(await mediaService.listUploadsByUser(user)).toHaveLength(1); expect(
await testSetup.mediaService.listUploadsByUser(user),
).toHaveLength(1);
// Remove /upload/ from path as we just need the filename. // Remove /upload/ from path as we just need the filename.
const fileName = url.replace('/uploads/', ''); const fileName = url.replace('/uploads/', '');
// delete the file afterwards // delete the file afterwards
@ -197,7 +180,11 @@ describe('Notes', () => {
}); });
}); });
it('works with an existing alias with permissions', async () => { it('works with an existing alias with permissions', async () => {
const note = await notesService.createNote(content, 'test3', user); const note = await testSetup.notesService.createNote(
content,
'test3',
user,
);
const updateNotePermission = new NotePermissionsUpdateDto(); const updateNotePermission = new NotePermissionsUpdateDto();
updateNotePermission.sharedToUsers = [ updateNotePermission.sharedToUsers = [
{ {
@ -206,8 +193,11 @@ describe('Notes', () => {
}, },
]; ];
updateNotePermission.sharedToGroups = []; updateNotePermission.sharedToGroups = [];
await notesService.updateNotePermissions(note, updateNotePermission); await testSetup.notesService.updateNotePermissions(
const updatedNote = await notesService.getNoteByIdOrAlias( note,
updateNotePermission,
);
const updatedNote = await testSetup.notesService.getNoteByIdOrAlias(
note.aliases.filter((alias) => alias.primary)[0].name, note.aliases.filter((alias) => alias.primary)[0].name,
); );
expect(updatedNote.userPermissions).toHaveLength(1); expect(updatedNote.userPermissions).toHaveLength(1);
@ -218,18 +208,22 @@ describe('Notes', () => {
user.username, user.username,
); );
expect(updatedNote.groupPermissions).toHaveLength(0); expect(updatedNote.groupPermissions).toHaveLength(0);
await request(app.getHttpServer()).delete('/notes/test3').expect(204); await request(testSetup.app.getHttpServer())
await expect(notesService.getNoteByIdOrAlias('test3')).rejects.toEqual( .delete('/notes/test3')
.expect(204);
await expect(
testSetup.notesService.getNoteByIdOrAlias('test3'),
).rejects.toEqual(
new NotInDBError("Note with id/alias 'test3' not found."), new NotInDBError("Note with id/alias 'test3' not found."),
); );
}); });
it('fails with a forbidden alias', async () => { it('fails with a forbidden alias', async () => {
await request(app.getHttpServer()) await request(testSetup.app.getHttpServer())
.delete(`/notes/${forbiddenNoteId}`) .delete(`/notes/${forbiddenNoteId}`)
.expect(400); .expect(400);
}); });
it('fails with a non-existing alias', async () => { it('fails with a non-existing alias', async () => {
await request(app.getHttpServer()) await request(testSetup.app.getHttpServer())
.delete('/notes/i_dont_exist') .delete('/notes/i_dont_exist')
.expect(404); .expect(404);
}); });
@ -238,28 +232,28 @@ describe('Notes', () => {
describe('PUT /notes/{note}', () => { describe('PUT /notes/{note}', () => {
const changedContent = 'New note text'; const changedContent = 'New note text';
it('works with existing alias', async () => { it('works with existing alias', async () => {
await notesService.createNote(content, 'test4', user); await testSetup.notesService.createNote(content, 'test4', user);
const response = await request(app.getHttpServer()) const response = await request(testSetup.app.getHttpServer())
.put('/notes/test4') .put('/notes/test4')
.set('Content-Type', 'text/markdown') .set('Content-Type', 'text/markdown')
.send(changedContent) .send(changedContent)
.expect(200); .expect(200);
expect( expect(
await notesService.getNoteContent( await testSetup.notesService.getNoteContent(
await notesService.getNoteByIdOrAlias('test4'), await testSetup.notesService.getNoteByIdOrAlias('test4'),
), ),
).toEqual(changedContent); ).toEqual(changedContent);
expect(response.body.content).toEqual(changedContent); expect(response.body.content).toEqual(changedContent);
}); });
it('fails with a forbidden alias', async () => { it('fails with a forbidden alias', async () => {
await request(app.getHttpServer()) await request(testSetup.app.getHttpServer())
.put(`/notes/${forbiddenNoteId}`) .put(`/notes/${forbiddenNoteId}`)
.set('Content-Type', 'text/markdown') .set('Content-Type', 'text/markdown')
.send(changedContent) .send(changedContent)
.expect(400); .expect(400);
}); });
it('fails with a non-existing alias', async () => { it('fails with a non-existing alias', async () => {
await request(app.getHttpServer()) await request(testSetup.app.getHttpServer())
.put('/notes/i_dont_exist') .put('/notes/i_dont_exist')
.set('Content-Type', 'text/markdown') .set('Content-Type', 'text/markdown')
.expect('Content-Type', /json/) .expect('Content-Type', /json/)
@ -269,8 +263,8 @@ describe('Notes', () => {
describe('GET /notes/{note}/metadata', () => { describe('GET /notes/{note}/metadata', () => {
it('returns complete metadata object', async () => { it('returns complete metadata object', async () => {
await notesService.createNote(content, 'test5', user); await testSetup.notesService.createNote(content, 'test5', user);
const metadata = await request(app.getHttpServer()) const metadata = await request(testSetup.app.getHttpServer())
.get('/notes/test5/metadata') .get('/notes/test5/metadata')
.expect(200); .expect(200);
expect(typeof metadata.body.id).toEqual('string'); expect(typeof metadata.body.id).toEqual('string');
@ -294,14 +288,14 @@ describe('Notes', () => {
}); });
it('fails with a forbidden alias', async () => { it('fails with a forbidden alias', async () => {
await request(app.getHttpServer()) await request(testSetup.app.getHttpServer())
.get(`/notes/${forbiddenNoteId}/metadata`) .get(`/notes/${forbiddenNoteId}/metadata`)
.expect(400); .expect(400);
}); });
it('fails with non-existing alias', async () => { it('fails with non-existing alias', async () => {
// check if a missing note correctly returns 404 // check if a missing note correctly returns 404
await request(app.getHttpServer()) await request(testSetup.app.getHttpServer())
.get('/notes/i_dont_exist/metadata') .get('/notes/i_dont_exist/metadata')
.expect('Content-Type', /json/) .expect('Content-Type', /json/)
.expect(404); .expect(404);
@ -309,14 +303,18 @@ describe('Notes', () => {
it('has the correct update/create dates', async () => { it('has the correct update/create dates', async () => {
// create a note // create a note
const note = await notesService.createNote(content, 'test5a', user); const note = await testSetup.notesService.createNote(
content,
'test5a',
user,
);
// save the creation time // save the creation time
const createDate = (await note.revisions)[0].createdAt; const createDate = (await note.revisions)[0].createdAt;
// wait one second // wait one second
await new Promise((r) => setTimeout(r, 1000)); await new Promise((r) => setTimeout(r, 1000));
// update the note // update the note
await notesService.updateNote(note, 'More test content'); await testSetup.notesService.updateNote(note, 'More test content');
const metadata = await request(app.getHttpServer()) const metadata = await request(testSetup.app.getHttpServer())
.get('/notes/test5a/metadata') .get('/notes/test5a/metadata')
.expect(200); .expect(200);
expect(metadata.body.createTime).toEqual(createDate.toISOString()); expect(metadata.body.createTime).toEqual(createDate.toISOString());
@ -326,8 +324,8 @@ describe('Notes', () => {
describe('GET /notes/{note}/revisions', () => { describe('GET /notes/{note}/revisions', () => {
it('works with existing alias', async () => { it('works with existing alias', async () => {
await notesService.createNote(content, 'test6', user); await testSetup.notesService.createNote(content, 'test6', user);
const response = await request(app.getHttpServer()) const response = await request(testSetup.app.getHttpServer())
.get('/notes/test6/revisions') .get('/notes/test6/revisions')
.expect('Content-Type', /json/) .expect('Content-Type', /json/)
.expect(200); .expect(200);
@ -335,14 +333,14 @@ describe('Notes', () => {
}); });
it('fails with a forbidden alias', async () => { it('fails with a forbidden alias', async () => {
await request(app.getHttpServer()) await request(testSetup.app.getHttpServer())
.get(`/notes/${forbiddenNoteId}/revisions`) .get(`/notes/${forbiddenNoteId}/revisions`)
.expect(400); .expect(400);
}); });
it('fails with non-existing alias', async () => { it('fails with non-existing alias', async () => {
// check if a missing note correctly returns 404 // check if a missing note correctly returns 404
await request(app.getHttpServer()) await request(testSetup.app.getHttpServer())
.get('/notes/i_dont_exist/revisions') .get('/notes/i_dont_exist/revisions')
.expect('Content-Type', /json/) .expect('Content-Type', /json/)
.expect(404); .expect(404);
@ -351,22 +349,26 @@ describe('Notes', () => {
describe('GET /notes/{note}/revisions/{revision-id}', () => { describe('GET /notes/{note}/revisions/{revision-id}', () => {
it('works with an existing alias', async () => { it('works with an existing alias', async () => {
const note = await notesService.createNote(content, 'test7', user); const note = await testSetup.notesService.createNote(
const revision = await notesService.getLatestRevision(note); content,
const response = await request(app.getHttpServer()) 'test7',
user,
);
const revision = await testSetup.notesService.getLatestRevision(note);
const response = await request(testSetup.app.getHttpServer())
.get(`/notes/test7/revisions/${revision.id}`) .get(`/notes/test7/revisions/${revision.id}`)
.expect('Content-Type', /json/) .expect('Content-Type', /json/)
.expect(200); .expect(200);
expect(response.body.content).toEqual(content); expect(response.body.content).toEqual(content);
}); });
it('fails with a forbidden alias', async () => { it('fails with a forbidden alias', async () => {
await request(app.getHttpServer()) await request(testSetup.app.getHttpServer())
.get(`/notes/${forbiddenNoteId}/revisions/1`) .get(`/notes/${forbiddenNoteId}/revisions/1`)
.expect(400); .expect(400);
}); });
it('fails with non-existing alias', async () => { it('fails with non-existing alias', async () => {
// check if a missing note correctly returns 404 // check if a missing note correctly returns 404
await request(app.getHttpServer()) await request(testSetup.app.getHttpServer())
.get('/notes/i_dont_exist/revisions/1') .get('/notes/i_dont_exist/revisions/1')
.expect('Content-Type', /json/) .expect('Content-Type', /json/)
.expect(404); .expect(404);
@ -375,20 +377,20 @@ describe('Notes', () => {
describe('GET /notes/{note}/content', () => { describe('GET /notes/{note}/content', () => {
it('works with an existing alias', async () => { it('works with an existing alias', async () => {
await notesService.createNote(content, 'test8', user); await testSetup.notesService.createNote(content, 'test8', user);
const response = await request(app.getHttpServer()) const response = await request(testSetup.app.getHttpServer())
.get('/notes/test8/content') .get('/notes/test8/content')
.expect(200); .expect(200);
expect(response.text).toEqual(content); expect(response.text).toEqual(content);
}); });
it('fails with a forbidden alias', async () => { it('fails with a forbidden alias', async () => {
await request(app.getHttpServer()) await request(testSetup.app.getHttpServer())
.get(`/notes/${forbiddenNoteId}/content`) .get(`/notes/${forbiddenNoteId}/content`)
.expect(400); .expect(400);
}); });
it('fails with non-existing alias', async () => { it('fails with non-existing alias', async () => {
// check if a missing note correctly returns 404 // check if a missing note correctly returns 404
await request(app.getHttpServer()) await request(testSetup.app.getHttpServer())
.get('/notes/i_dont_exist/content') .get('/notes/i_dont_exist/content')
.expect('Content-Type', /text\/markdown/) .expect('Content-Type', /text\/markdown/)
.expect(404); .expect(404);
@ -399,9 +401,17 @@ describe('Notes', () => {
it('works', async () => { it('works', async () => {
const alias = 'test9'; const alias = 'test9';
const extraAlias = 'test10'; const extraAlias = 'test10';
const note1 = await notesService.createNote(content, alias, user); const note1 = await testSetup.notesService.createNote(
const note2 = await notesService.createNote(content, extraAlias, user); content,
const httpServer = app.getHttpServer(); alias,
user,
);
const note2 = await testSetup.notesService.createNote(
content,
extraAlias,
user,
);
const httpServer = testSetup.app.getHttpServer();
const response = await request(httpServer) const response = await request(httpServer)
.get(`/notes/${alias}/media/`) .get(`/notes/${alias}/media/`)
.expect('Content-Type', /json/) .expect('Content-Type', /json/)
@ -409,8 +419,16 @@ describe('Notes', () => {
expect(response.body).toHaveLength(0); expect(response.body).toHaveLength(0);
const testImage = await fs.readFile('test/public-api/fixtures/test.png'); const testImage = await fs.readFile('test/public-api/fixtures/test.png');
const url0 = await mediaService.saveFile(testImage, user, note1); const url0 = await testSetup.mediaService.saveFile(
const url1 = await mediaService.saveFile(testImage, user, note2); testImage,
user,
note1,
);
const url1 = await testSetup.mediaService.saveFile(
testImage,
user,
note2,
);
const responseAfter = await request(httpServer) const responseAfter = await request(httpServer)
.get(`/notes/${alias}/media/`) .get(`/notes/${alias}/media/`)
@ -427,15 +445,19 @@ describe('Notes', () => {
await fs.rmdir(uploadPath, { recursive: true }); await fs.rmdir(uploadPath, { recursive: true });
}); });
it('fails, when note does not exist', async () => { it('fails, when note does not exist', async () => {
await request(app.getHttpServer()) await request(testSetup.app.getHttpServer())
.get(`/notes/i_dont_exist/media/`) .get(`/notes/i_dont_exist/media/`)
.expect('Content-Type', /json/) .expect('Content-Type', /json/)
.expect(404); .expect(404);
}); });
it("fails, when user can't read note", async () => { it("fails, when user can't read note", async () => {
const alias = 'test11'; const alias = 'test11';
await notesService.createNote('This is a test note.', alias, user2); await testSetup.notesService.createNote(
await request(app.getHttpServer()) 'This is a test note.',
alias,
user2,
);
await request(testSetup.app.getHttpServer())
.get(`/notes/${alias}/media/`) .get(`/notes/${alias}/media/`)
.expect('Content-Type', /json/) .expect('Content-Type', /json/)
.expect(401); .expect(401);
@ -443,6 +465,6 @@ describe('Notes', () => {
}); });
afterAll(async () => { afterAll(async () => {
await app.close(); await testSetup.app.close();
}); });
}); });

10
test/test-setup.ts
View file

@ -9,6 +9,7 @@ import { Test, TestingModule } from '@nestjs/testing';
import { TypeOrmModule } from '@nestjs/typeorm'; import { TypeOrmModule } from '@nestjs/typeorm';
import { PrivateApiModule } from '../src/api/private/private-api.module'; import { PrivateApiModule } from '../src/api/private/private-api.module';
import { PublicApiModule } from '../src/api/public/public-api.module';
import { AuthModule } from '../src/auth/auth.module'; import { AuthModule } from '../src/auth/auth.module';
import { MockAuthGuard } from '../src/auth/mock-auth.guard'; import { MockAuthGuard } from '../src/auth/mock-auth.guard';
import { TokenAuthGuard } from '../src/auth/token.strategy'; import { TokenAuthGuard } from '../src/auth/token.strategy';
@ -22,7 +23,9 @@ import { HistoryModule } from '../src/history/history.module';
import { IdentityService } from '../src/identity/identity.service'; import { IdentityService } from '../src/identity/identity.service';
import { LoggerModule } from '../src/logger/logger.module'; import { LoggerModule } from '../src/logger/logger.module';
import { MediaModule } from '../src/media/media.module'; import { MediaModule } from '../src/media/media.module';
import { MediaService } from '../src/media/media.service';
import { NotesModule } from '../src/notes/notes.module'; import { NotesModule } from '../src/notes/notes.module';
import { NotesService } from '../src/notes/notes.service';
import { PermissionsModule } from '../src/permissions/permissions.module'; import { PermissionsModule } from '../src/permissions/permissions.module';
import { UsersModule } from '../src/users/users.module'; import { UsersModule } from '../src/users/users.module';
import { UsersService } from '../src/users/users.service'; import { UsersService } from '../src/users/users.service';
@ -34,6 +37,8 @@ export class TestSetup {
userService: UsersService; userService: UsersService;
configService: ConfigService; configService: ConfigService;
identityService: IdentityService; identityService: IdentityService;
notesService: NotesService;
mediaService: MediaService;
public static async create(): Promise<TestSetup> { public static async create(): Promise<TestSetup> {
const testSetup = new TestSetup(); const testSetup = new TestSetup();
@ -50,6 +55,7 @@ export class TestSetup {
externalServicesConfigMock, externalServicesConfigMock,
], ],
}), }),
PublicApiModule,
PrivateApiModule, PrivateApiModule,
NotesModule, NotesModule,
PermissionsModule, PermissionsModule,
@ -77,6 +83,10 @@ export class TestSetup {
testSetup.moduleRef.get<ConfigService>(ConfigService); testSetup.moduleRef.get<ConfigService>(ConfigService);
testSetup.identityService = testSetup.identityService =
testSetup.moduleRef.get<IdentityService>(IdentityService); testSetup.moduleRef.get<IdentityService>(IdentityService);
testSetup.notesService =
testSetup.moduleRef.get<NotesService>(NotesService);
testSetup.mediaService =
testSetup.moduleRef.get<MediaService>(MediaService);
testSetup.app = testSetup.moduleRef.createNestApplication(); testSetup.app = testSetup.moduleRef.createNestApplication();