github/hedgedoc
1
0
Fork 0
mirror of https://github.com/hedgedoc/hedgedoc.git synced 2024-11-26 11:43:59 -05:00
Code Issues Projects Releases Packages Wiki Activity

fix(websocket): error when leaving realtime-note

Browse source 
When a user left a realtime-note, the awareness tried to send events even after the socket was closed, resulting in the app crashing.
This fix adds the check that the socket is still open before sending any messages.

Signed-off-by: Erik Michelson <github@erik.michelson.eu>
This commit is contained in:
Erik Michelson 2022-08-27 18:29:51 +02:00 committed by Tilman Vatteroth
parent 26d9bf4dde
commit 1938b6eefe
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/components/editor-page/editor-pane/hooks/yjs/websocket-connection.ts
View file

@ -51,7 +51,7 @@ export class WebsocketConnection extends WebsocketTransporter {
private bindYDocEvents(doc: Doc): void { private bindYDocEvents(doc: Doc): void {
doc.on('destroy', () => this.disconnect()) doc.on('destroy', () => this.disconnect())
doc.on('update', (update: Uint8Array, origin: unknown) => { doc.on('update', (update: Uint8Array, origin: unknown) => {
if (origin !== this && this.isSynced()) { if (origin !== this && this.isSynced() && this.isWebSocketOpen()) {
this.send(encodeDocumentUpdateMessage(update)) this.send(encodeDocumentUpdateMessage(update))
} }
}) })