github/hedgedoc
1
0
Fork 0
mirror of https://github.com/hedgedoc/hedgedoc.git synced 2024-11-22 09:46:30 -05:00
Code Issues Projects Releases Packages Wiki Activity

Use useStaticAssets instead of @nestjs/serve-static

Browse source 
`serve-static` does not work with `createTestingModule` and is not recommended when "just" serving a few images.

See https://github.com/nestjs/serve-static/issues/240

Signed-off-by: David Mehren <git@herrmehren.de>
This commit is contained in:
David Mehren 2020-10-24 11:32:23 +02:00
parent bd1a6e528e
commit 15db6a9b2a
No known key found for this signature in database
GPG key ID: 185982BA4C42B7C3
4 changed files with 6 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
package.json
View file

@ -25,7 +25,6 @@
"@nestjs/common": "^7.0.0", "@nestjs/common": "^7.0.0",
"@nestjs/core": "^7.0.0", "@nestjs/core": "^7.0.0",
"@nestjs/platform-express": "^7.0.0", "@nestjs/platform-express": "^7.0.0",
"@nestjs/serve-static": "^2.1.3",
"@nestjs/swagger": "^4.5.12", "@nestjs/swagger": "^4.5.12",
"@nestjs/typeorm": "^7.1.0", "@nestjs/typeorm": "^7.1.0",
"class-transformer": "^0.2.3", "class-transformer": "^0.2.3",

5
src/app.module.ts
View file

@ -22,11 +22,6 @@ import { UsersModule } from './users/users.module';
autoLoadEntities: true, autoLoadEntities: true,
synchronize: true, synchronize: true,
}), }),
ServeStaticModule.forRoot({
rootPath: join(__dirname, '..'),
// TODO: Get uploads directory from config
renderPath: 'uploads',
}),
NotesModule, NotesModule,
UsersModule, UsersModule,
RevisionsModule, RevisionsModule,

7
src/main.ts
View file

@ -1,11 +1,12 @@
import { ValidationPipe } from '@nestjs/common'; import { ValidationPipe } from '@nestjs/common';
import { NestFactory } from '@nestjs/core'; import { NestFactory } from '@nestjs/core';
import { NestExpressApplication } from '@nestjs/platform-express';
import { DocumentBuilder, SwaggerModule } from '@nestjs/swagger'; import { DocumentBuilder, SwaggerModule } from '@nestjs/swagger';
import { AppModule } from './app.module'; import { AppModule } from './app.module';
import { NestConsoleLoggerService } from './logger/nest-console-logger.service'; import { NestConsoleLoggerService } from './logger/nest-console-logger.service';
async function bootstrap() { async function bootstrap() {
const app = await NestFactory.create(AppModule); const app = await NestFactory.create<NestExpressApplication>(AppModule);
const logger = await app.resolve(NestConsoleLoggerService); const logger = await app.resolve(NestConsoleLoggerService);
logger.log('Switching logger', 'AppBootstrap'); logger.log('Switching logger', 'AppBootstrap');
app.useLogger(logger); app.useLogger(logger);
@ -24,6 +25,10 @@ async function bootstrap() {
transform: true, transform: true,
}), }),
); );
// TODO: Get uploads directory from config
app.useStaticAssets('uploads', {
prefix: '/uploads',
});
await app.listen(3000); await app.listen(3000);
logger.log('Listening on port 3000', 'AppBootstrap'); logger.log('Listening on port 3000', 'AppBootstrap');
} }

7
yarn.lock
View file

@ -614,13 +614,6 @@
"@angular-devkit/schematics" "9.1.7" "@angular-devkit/schematics" "9.1.7"
fs-extra "9.0.0" fs-extra "9.0.0"
"@nestjs/serve-static@^2.1.3":
version "2.1.3"
resolved "https://registry.yarnpkg.com/@nestjs/serve-static/-/serve-static-2.1.3.tgz#bdcb6d3463d193153b334212facc24a9767046e9"
integrity sha512-9xyysggaOdfbABWqhty+hAkauDWv/Q8YKHm4OMXdQbQei5tquFuTjiSx8IFDOZeSOKlA9fjBq/2MXCJRSo23SQ==
dependencies:
path-to-regexp "0.1.7"
"@nestjs/swagger@^4.5.12": "@nestjs/swagger@^4.5.12":
version "4.5.12" version "4.5.12"
resolved "https://registry.yarnpkg.com/@nestjs/swagger/-/swagger-4.5.12.tgz#e8aa65fbb0033007ece1d494b002f47ff472c20b" resolved "https://registry.yarnpkg.com/@nestjs/swagger/-/swagger-4.5.12.tgz#e8aa65fbb0033007ece1d494b002f47ff472c20b"