github/hedgedoc
1
0
Fork 0
mirror of https://github.com/hedgedoc/hedgedoc.git synced 2024-10-18 21:30:15 -04:00
Code Issues Projects Releases Packages Wiki Activity

fix(motd): remove redundant suspense

Browse source 
Signed-off-by: Tilman Vatteroth <git@tilmanvatteroth.de>
This commit is contained in:
Tilman Vatteroth 2022-10-08 17:31:05 +02:00
parent 6d580a0eee
commit 07c77d633c
1 changed files with 9 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
src/components/common/motd-modal/motd-modal.tsx
View file

@ -4,11 +4,10 @@
* SPDX-License-Identifier: AGPL-3.0-only * SPDX-License-Identifier: AGPL-3.0-only
*/ */
import React, { Suspense, useCallback, useMemo, useEffect, useState } from 'react' import React, { useCallback, useMemo, useEffect, useState } from 'react'
import { Button, Modal } from 'react-bootstrap' import { Button, Modal } from 'react-bootstrap'
import { CommonModal } from '../modals/common-modal' import { CommonModal } from '../modals/common-modal'
import { Trans, useTranslation } from 'react-i18next' import { Trans, useTranslation } from 'react-i18next'
import { WaitSpinner } from '../wait-spinner/wait-spinner'
import { fetchMotd, MOTD_LOCAL_STORAGE_KEY } from './fetch-motd' import { fetchMotd, MOTD_LOCAL_STORAGE_KEY } from './fetch-motd'
import { useAsync } from 'react-use' import { useAsync } from 'react-use'
import { Logger } from '../../../utils/logger' import { Logger } from '../../../utils/logger'
@ -53,16 +52,14 @@ export const MotdModal: React.FC = () => {
return ( return (
<CommonModal show={!!lines && !loading && !error && !dismissed} title={'motd.title'} {...cypressId('motd-modal')}> <CommonModal show={!!lines && !loading && !error && !dismissed} title={'motd.title'} {...cypressId('motd-modal')}>
<Modal.Body className={'bg-light'}> <Modal.Body className={'bg-light'}>
<Suspense fallback={<WaitSpinner />}> <EditorToRendererCommunicatorContextProvider>
<EditorToRendererCommunicatorContextProvider> <RenderIframe
<RenderIframe frameClasses={'w-100'}
frameClasses={'w-100'} rendererType={RendererType.MOTD}
rendererType={RendererType.MOTD} markdownContentLines={lines as string[]}
markdownContentLines={lines as string[]} adaptFrameHeightToContent={true}
adaptFrameHeightToContent={true} />
/> </EditorToRendererCommunicatorContextProvider>
</EditorToRendererCommunicatorContextProvider>
</Suspense>
</Modal.Body> </Modal.Body>
<Modal.Footer> <Modal.Footer>
<Button variant={'success'} onClick={dismiss} {...testId('motd-dismiss')} {...cypressId('motd-dismiss')}> <Button variant={'success'} onClick={dismiss} {...testId('motd-dismiss')} {...cypressId('motd-dismiss')}>