From 01d7eb952949d798cd7204e9fc0851dacd89f7f4 Mon Sep 17 00:00:00 2001 From: Tilman Vatteroth Date: Wed, 17 Jan 2024 13:08:08 +0100 Subject: [PATCH] fix(deps): bump minimum node version to v20 With node 18 the tests always crash. Signed-off-by: Tilman Vatteroth --- .github/workflows/test-and-build.yml | 2 +- docs/content/how-to/develop/setup.md | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test-and-build.yml b/.github/workflows/test-and-build.yml index 6c3221ad1..57fa471c1 100644 --- a/.github/workflows/test-and-build.yml +++ b/.github/workflows/test-and-build.yml @@ -25,7 +25,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - node: [ '18', '20' ] # Are you changing this? Don't forget to update the min. and recommended node version in getting-started.md! + node: [ '20' ] # Are you changing this? Don't forget to update the min. and recommended node version in docs/content/how-to/develop/setup.md! include: - node: '20' coverage: true diff --git a/docs/content/how-to/develop/setup.md b/docs/content/how-to/develop/setup.md index 35cb46862..365940d43 100644 --- a/docs/content/how-to/develop/setup.md +++ b/docs/content/how-to/develop/setup.md @@ -25,7 +25,7 @@ and the provided configuration. ``` -2. Install Node.js. You need at least Node 16, but we recommend Node 20. +2. Install Node.js. You need at least Node 20. 3. Install [Yarn][yarn] 4. Install Caddy (select one of the two options) - [Download][caddy] and place the `caddy` binary in `dev-reverse-proxy`. @@ -48,7 +48,7 @@ The following sections describe a more detailed setup of all components. If you want to run HedgeDoc in dev mode some preconditions have to be met. -1. Make sure that Node.js is installed. You need at least Node 16, but we recommend Node 18. +1. Make sure that Node.js is installed. You need at least Node 20. 2. Make sure that [Yarn][yarn] is installed. 3. Clone this repo (e.g. `git clone https://github.com/hedgedoc/hedgedoc.git hedgedoc`)