2016-09-27 13:39:44 -04:00
|
|
|
# Contributing
|
|
|
|
|
|
|
|
When contributing to this repository, please first discuss the change you wish to make via issue,
|
2018-06-22 15:07:30 -04:00
|
|
|
email, or any other method with the owners of this repository before making a change.
|
2016-09-27 13:39:44 -04:00
|
|
|
|
2020-07-01 05:52:17 -04:00
|
|
|
Please note we have a [code of conduct](CODE-OF-CONDUCT.md), please follow it in all your
|
2019-03-31 19:26:36 -04:00
|
|
|
interactions with the project.
|
2016-09-27 13:39:44 -04:00
|
|
|
|
|
|
|
## Pull Request Process
|
2020-07-01 05:52:17 -04:00
|
|
|
|
2017-10-11 14:07:03 -04:00
|
|
|
1. Ensure you signed all your commits with Developer Certificate of Origin (DCO).
|
2020-07-01 05:52:17 -04:00
|
|
|
|
2018-06-22 15:07:30 -04:00
|
|
|
2. Ensure any install or build dependencies are removed before the end of the layer when doing a
|
2016-09-27 13:39:44 -04:00
|
|
|
build.
|
2020-07-01 05:52:17 -04:00
|
|
|
|
2018-06-22 15:07:30 -04:00
|
|
|
3. Update the README.md with details of changes to the interface, this includes new environment
|
2016-09-27 13:39:44 -04:00
|
|
|
variables, exposed ports, useful file locations and container parameters.
|
2020-07-01 05:52:17 -04:00
|
|
|
|
2017-10-11 14:07:03 -04:00
|
|
|
4. Increase the version numbers in any examples files and the README.md to the new version that this
|
2016-09-27 13:39:44 -04:00
|
|
|
Pull Request would represent. The versioning scheme we use is [SemVer](http://semver.org/).
|
2020-07-01 05:52:17 -04:00
|
|
|
|
2018-06-22 15:07:30 -04:00
|
|
|
5. You may merge the Pull Request in once you have the sign-off of two other developers, or if you
|
2016-09-27 13:39:44 -04:00
|
|
|
do not have permission to do that, you may request the second reviewer to merge it for you.
|
|
|
|
|
2019-03-31 19:26:36 -04:00
|
|
|
## Sign your work
|
2017-10-11 13:44:55 -04:00
|
|
|
|
|
|
|
We use the Developer Certificate of Origin (DCO) as a additional safeguard
|
2018-06-22 15:07:30 -04:00
|
|
|
for the CodiMD project. This is a well established and widely used
|
2017-10-11 13:44:55 -04:00
|
|
|
mechanism to assure contributors have confirmed their right to license
|
|
|
|
their contribution under the project's license.
|
2019-06-10 11:24:28 -04:00
|
|
|
Please read [docs/legal/developer-certificate-of-origin.txt][dcofile].
|
2017-10-11 13:44:55 -04:00
|
|
|
If you can certify it, then just add a line to every git commit message:
|
|
|
|
|
2020-07-01 05:52:17 -04:00
|
|
|
```git
|
2017-10-11 13:44:55 -04:00
|
|
|
Signed-off-by: Random J Developer <random@developer.example.org>
|
2020-07-01 05:52:17 -04:00
|
|
|
```
|
2017-10-11 13:44:55 -04:00
|
|
|
|
|
|
|
Use your real name (sorry, no pseudonyms or anonymous contributions).
|
|
|
|
If you set your `user.name` and `user.email` git configs, you can sign your
|
|
|
|
commit automatically with `git commit -s`. You can also use git [aliases](https://git-scm.com/book/tr/v2/Git-Basics-Git-Aliases)
|
|
|
|
like `git config --global alias.ci 'commit -s'`. Now you can commit with
|
|
|
|
`git ci` and the commit will be signed.
|