From cd084812cc7097039d0404755df589345c23264a Mon Sep 17 00:00:00 2001 From: Brandon Rozek Date: Sun, 4 May 2025 20:29:02 -0400 Subject: [PATCH] Removed a useless optimization and added one when negation is defined --- vsp.py | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/vsp.py b/vsp.py index 1efd84c..e5a715b 100644 --- a/vsp.py +++ b/vsp.py @@ -78,16 +78,11 @@ def quick_vsp_unsat_incomplete(xs, ys, model, top, bottom, negation_defined) -> # skip this pair if top is not None and top in ys: return True + if negation_defined and bottom is not None and bottom in ys: + return True if bottom is not None and bottom in xs: return True - - # If a subalgebra doesn't have at least one - # designated value, move onto the next pair. - # Depends on no intersection between xs and ys - if xs.isdisjoint(model.designated_values): - return True - - if ys.isdisjoint(model.designated_values): + if negation_defined and top is not None and top in xs: return True # If the two subalgebras intersect, move